Code review comment for lp:~xaav/loggerhead/export-tarball

Revision history for this message
Martin Pool (mbp) wrote :

[fix] It looks like you want tarballs disabled by default (which I agree with), so it seems a bit strange to me that the keyword arguments default to true.

[fix] You seem to be giving people uncompressed tarballs? .tgz is probably better. The default value to export_archive is unnecessary and probably just a distraction if it's called from only one place that does specify the value.

Were you able to get the tests to run and pass?

Aside from that it looks good to me.

review: Needs Fixing

« Back to merge proposal