Merge lp:~wxl/ubuntu/hirsute/apport/ubuntu into lp:~ubuntu-core-dev/ubuntu/hirsute/apport/ubuntu

[ԜаӀtеr Ⅼарсһуnѕkі]

Change default for CasperMD5CheckResult to "unknown."

The reported result of the casper MD5 check is set to "skip" before it is then set to whatever value is found in the results file. This works fine except for older installs before the file check was in place and before the results file was created. That means that new bug reports on recent release versions that were upgraded from older ones will show "skip" suggesting that they skipped the MD5 check, when the reality is actually that we simply don't know what happened.

[Brian Murray (brian-murray)]

I don't recall if a 'result' of 'skip' is actually written to the md5check file. Do you happen to know the answer?

review: Needs Information

[ԜаӀtеr Ⅼарсһуnѕkі (wxl)]

Yep. Just opened up a Groovy VM and booted with `fsck.mode=skip` and /run/casper-md5check.json had the following contents:

    {
      "result": "skip"
    }

[Brian Murray (brian-murray)]

Looking at Dimitri's notes again (https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1870408) the absence of the file can also mean that it was skipped. So that's why I went with 'skip' as the default but I can see how this is confusing and 'unknown' is more accurate. Thanks for the fix!

=== modified file 'apport/hookutils.py'
--- apport/hookutils.py	2020-09-21 17:18:15 +0000
+++ apport/hookutils.py	2021-01-26 19:26:46 +0000
@@ -939,7 +939,7 @@
 
 def attach_casper_md5check(report, location):
     '''attach the results of the casper md5check of install media'''
-    result = 'skip'
+    result = 'unknown'
     mismatches = []
     if os.path.exists(location):
         with open(location) as json_file: