ubiquity

Merge lp:~wxl/ubiquity/ubiquity into lp:ubiquity

  1. ubiquity
  2. Merge into trunk
Proposed by Walter Lapchynski on 2017-01-31
Status: Merged
Approved by: Mathieu Trudel-Lapierre on 2017-02-03
Approved revision: 6514
Merged at revision: 6516
Proposed branch: lp:~wxl/ubiquity/ubiquity
Merge into: lp:ubiquity
Diff against target: 16 lines (+6/-0)
1 file modified
ubiquity/plugins/ubi-prepare.py (+6/-0)
To merge this branch: bzr merge lp:~wxl/ubiquity/ubiquity
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre 2017-01-31 Approve on 2017-02-03
Review via email: mp+315967@code.launchpad.net

Description of the Change

Provides an error when insufficient disk space is detected in the Prepare stage of Ubiquity when installing Kubuntu.

Previously, the show_insufficient_space_page() definition contained nothing more than a return.

This copies ~clementlefebvre's fix for Mint KDE on Github:
   https://github.com/linuxmint/ubiquity/commit/47d7f1e042de292d66f482b76117970c1581c375

Note that QtGui from PyQt4 is used to create a dialog.

To post a comment you must log in.
Mathieu Trudel-Lapierre (cyphermox) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubiquity/plugins/ubi-prepare.py'
2--- ubiquity/plugins/ubi-prepare.py 2016-09-26 18:16:26 +0000
3+++ ubiquity/plugins/ubi-prepare.py 2017-01-31 04:42:30 +0000
4@@ -290,6 +290,12 @@
5 self.plugin_widgets = self.page
6
7 def show_insufficient_space_page(self, required, free):
8+ from PyQt4 import QtGui
9+ dialog = QtGui.QMessageBox(self.page)
10+ dialog.setText(required)
11+ dialog.setDetailedText(free)
12+ dialog.exec_()
13+ sys.exit(1)
14 return
15
16 def set_using_secureboot(self, secureboot):

Subscribers

People subscribed via source and target branches

to status/vote changes: