Merge lp:~wxl/loco-team-portal/more-details into lp:loco-team-portal

Proposed by Walter Lapchynski
Status: Needs review
Proposed branch: lp:~wxl/loco-team-portal/more-details
Merge into: lp:loco-team-portal
Diff against target: 12 lines (+1/-1)
1 file modified
loco_directory/templates/teams/team_detail.html (+1/-1)
To merge this branch: bzr merge lp:~wxl/loco-team-portal/more-details
Reviewer Review Type Date Requested Status
Dani Llewellyn (community) Approve
Adnane Belmadiaf Pending
LoCo Team Portal Developers Pending
Review via email: mp+250210@code.launchpad.net

Description of the change

In Team Details, if a user is not a member (in an else of a blank is_member), "Join This Team!" is displayed in the nav, but at no point anywhere on the page is the Launchpad Team mentioned. So if is_member succeeds, it now now offers "Team Details."

To post a comment you must log in.
Revision history for this message
Pablo Rubianes (pablorubianes-uy) wrote :

As LoCo Council member I don't think that encourage people to join every team on the list is a good idea, as you need to join just your LoCo.
I think that provide more stuff to the members is a good idea but not encouraging people to join every LoCo.

Pablo

Revision history for this message
Walter Lapchynski (wxl) wrote :

This change doesn't do anything different with regards to joining teams. That was already there for non-team members. All it does is add a "Team Details" link if they are a member of the team.

Revision history for this message
Walter Lapchynski (wxl) wrote :

Added daker per dholbach's suggestion.

Revision history for this message
Dani Llewellyn (diddledani) wrote :

Looks good to me.

review: Approve

Unmerged revisions

683. By Walter Lapchynski

added lp team details to nav for members

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/templates/teams/team_detail.html'
2--- loco_directory/templates/teams/team_detail.html 2013-11-17 05:32:01 +0000
3+++ loco_directory/templates/teams/team_detail.html 2015-02-18 20:59:20 +0000
4@@ -5,7 +5,7 @@
5
6 {% block sub_nav_links %}
7 <li><a class="sub-nav-item" href="{% url team-list %}" title="{% trans "Back to Teams List" %}">{% trans "Back to Teams List" %}</a></li>
8- {% if is_member %}{% else %}<li><a class="sub-nav-item" href="https://launchpad.net/~{{ team.lp_name }}/+join">{% trans "Join This Team!" %}</a></li>{% endif %}
9+ {% if is_member %}<li><a class="sub-nav-item" href="https://launchpad.net/~{{ team.lp_name }}">{% trans "Team Details" %}</a></li>{% else %}<li><a class="sub-nav-item" href="https://launchpad.net/~{{ team.lp_name }}/+join">{% trans "Join This Team!" %}</a></li>{% endif %}
10 {% if is_admin %}<li><a class="sub-nav-item" href="{% url team-edit team.lp_name %}" title="{% trans "Edit Details" %}">{% trans "Edit Details" %}</a></li>{% endif %}
11 {% if is_admin and not team.active %}<li><a class="sub-nav-item" href="{% url select-other-team team.lp_name %}" title="{% trans "Merge with another team" %}">{% trans "Merge team" %}</a></li>{% endif %}
12 {% if is_member %}<li><a class="sub-nav-item" href="{% url team-event-new team.lp_name %}" title="{% trans "Add New Event" %}">{% trans "Add New Event" %}</a></li>{% endif %}

Subscribers

People subscribed via source and target branches