Merge ~wxl/kubuntu-packaging/+git/kdepim-runtime:kubuntu_bionic_archive into ~kubuntu-packagers/kubuntu-packaging/+git/kdepim-runtime:kubuntu_bionic_archive

Proposed by ԜаӀtеr Ⅼарсһуnѕkі
Status: Merged
Merged at revision: 6fbf253a21277353dcb713e35546e4dd85ae280c
Proposed branch: ~wxl/kubuntu-packaging/+git/kdepim-runtime:kubuntu_bionic_archive
Merge into: ~kubuntu-packagers/kubuntu-packaging/+git/kdepim-runtime:kubuntu_bionic_archive
Diff against target: 69 lines (+49/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/find_resource_interface_when_running_test_environment.diff (+42/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Simon Quigley Approve
Review via email: mp+334877@code.launchpad.net

Description of the change

Add upstream find_resource_interface_when_running_test_environment patch.

To post a comment you must log in.
Revision history for this message
Simon Quigley (tsimonq2) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 1a2be7a..75ef37b 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+kdepim-runtime (4:17.08.3-0ubuntu2) bionic; urgency=medium
7+
8+ * Add upstream find_resource_interface_when_running_test_environment patch.
9+
10+ -- Walter Lapchynski <wxl@ubuntu.com> Thu, 07 Dec 2017 01:50:06 +0000
11+
12 kdepim-runtime (4:17.08.3-0ubuntu1) bionic; urgency=medium
13
14 * New build depend on libkf5contacteditor-dev
15diff --git a/debian/patches/find_resource_interface_when_running_test_environment.diff b/debian/patches/find_resource_interface_when_running_test_environment.diff
16new file mode 100644
17index 0000000..faaf150
18--- /dev/null
19+++ b/debian/patches/find_resource_interface_when_running_test_environment.diff
20@@ -0,0 +1,42 @@
21+Description: Fix finding resource interface when running the test environment
22+Origin: upstream, https://github.com/KDE/kdepim-runtime/commit/8b7e7bfd2e9751e6bd7f4a292c42dc5468dacf0a?diff=unified
23+---
24+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
25+Index: b/resources/maildir/autotests/synctest.cpp
26+===================================================================
27+--- a/resources/maildir/autotests/synctest.cpp
28++++ b/resources/maildir/autotests/synctest.cpp
29+@@ -47,7 +47,12 @@ void SyncTest::initTestCase()
30+ QVERIFY(agentCreateJob->exec());
31+ mMaildirIdentifier = agentCreateJob->instance().identifier();
32+
33+- OrgKdeAkonadiMaildirSettingsInterface interface(QStringLiteral("org.freedesktop.Akonadi.Resource.%1").arg(mMaildirIdentifier), QStringLiteral("/"), QDBusConnection::sessionBus());
34++ QString service = QStringLiteral("org.freedesktop.Akonadi.Resource.") + mMaildirIdentifier;
35++ if (Akonadi::ServerManager::hasInstanceIdentifier()) {
36++ service += QLatin1Char('.') + Akonadi::ServerManager::instanceIdentifier();
37++ }
38++
39++ OrgKdeAkonadiMaildirSettingsInterface interface(service, QStringLiteral("/"), QDBusConnection::sessionBus());
40+ QVERIFY(interface.isValid());
41+ const QString mailPath = QFINDTESTDATA("maildir");
42+ QVERIFY(!mailPath.isEmpty());
43+Index: b/resources/pop3/autotests/pop3test.cpp
44+===================================================================
45+--- a/resources/pop3/autotests/pop3test.cpp
46++++ b/resources/pop3/autotests/pop3test.cpp
47+@@ -71,8 +71,14 @@ void Pop3Test::initTestCase()
48+ //
49+ QString maildirRootPath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QLatin1Char('/') + QLatin1String("tester");
50+ mMaildirPath = maildirRootPath + QLatin1String("/new");
51++
52++ QString service = QLatin1String("org.freedesktop.Akonadi.Resource.") + mMaildirIdentifier;
53++ if (Akonadi::ServerManager::hasInstanceIdentifier()) {
54++ service += QLatin1Char('.') + Akonadi::ServerManager::instanceIdentifier();
55++ }
56++
57+ mMaildirSettingsInterface = new OrgKdeAkonadiMaildirSettingsInterface(
58+- QLatin1String("org.freedesktop.Akonadi.Resource.") + mMaildirIdentifier,
59++ service,
60+ QStringLiteral("/Settings"), QDBusConnection::sessionBus(), this);
61+ QDBusReply<void> setPathReply = mMaildirSettingsInterface->setPath(maildirRootPath);
62+ QVERIFY(setPathReply.isValid());
63diff --git a/debian/patches/series b/debian/patches/series
64index 138e65a..1e4a5a5 100644
65--- a/debian/patches/series
66+++ b/debian/patches/series
67@@ -1 +1,2 @@
68 kubuntu_disable_failing_tests.diff
69+find_resource_interface_when_running_test_environment.diff

Subscribers

People subscribed via source and target branches