Merge lp:~woutervb/ols-jenkaas/update_before_charm_build into lp:~ols-jenkaas-admins/ols-jenkaas/trunk

Proposed by Wouter van Bommel
Status: Merged
Approved by: William Grant
Approved revision: 862
Merged at revision: 862
Proposed branch: lp:~woutervb/ols-jenkaas/update_before_charm_build
Merge into: lp:~ols-jenkaas-admins/ols-jenkaas/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
jobs/snapmodels.yaml (+1/-1)
To merge this branch: bzr merge lp:~woutervb/ols-jenkaas/update_before_charm_build
Reviewer Review Type Date Requested Status
William Grant Approve
Review via email: mp+436175@code.launchpad.net

Commit message

Make sure that python dependencies are updated before the charm is build

To post a comment you must log in.
Revision history for this message
Tong Shinn (tshinn) wrote :

As part of this same MP, could we apply the fix for other jobs? It looks like snapdevicegw is failing for the exact same reason.

Revision history for this message
Wouter van Bommel (woutervb) wrote :

> As part of this same MP, could we apply the fix for other jobs? It looks like
> snapdevicegw is failing for the exact same reason.

Yes will work on that, currently this was the only one failing, and wanted to get it fixed asap

Revision history for this message
William Grant (wgrant) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/snapmodels.yaml'
2--- jobs/snapmodels.yaml 2023-01-09 04:08:58 +0000
3+++ jobs/snapmodels.yaml 2023-01-23 01:24:45 +0000
4@@ -5,7 +5,7 @@
5 trunk: 'lp:snapmodels'
6 setup: 'OLS_WHEELS_DIR=/workspace/ols-wheels make update-dependencies bootstrap'
7 landing-tests: 'OLS_WHEELS_DIR=/workspace/ols-wheels make landing'
8- build-command: 'OLS_WHEELS_DIR=/workspace/ols-wheels make charm-publish'
9+ build-command: 'OLS_WHEELS_DIR=/workspace/ols-wheels make update-dependencies charm-publish'
10 charm-repo: 'lp:~ubuntuone-pqm-team/snapmodels/+git/charm-build-snapmodels'
11 deploy-group: 'snap-store'
12 jobs:

Subscribers

People subscribed via source and target branches