Merge lp:~wookey/xdeb/xdeb-allow-null-cross into lp:xdeb

Proposed by Wookey
Status: Merged
Merged at revision: 266
Proposed branch: lp:~wookey/xdeb/xdeb-allow-null-cross
Merge into: lp:xdeb
Diff against target: 24 lines (+2/-1)
2 files modified
debian/changelog (+1/-0)
xdeb.py (+1/-1)
To merge this branch: bzr merge lp:~wookey/xdeb/xdeb-allow-null-cross
Reviewer Review Type Date Requested Status
Colin Watson Approve
Review via email: mp+75575@code.launchpad.net

Description of the change

    Don't fail if null dpkg-cross packages are found LP: #731079

    This is a very simple-minded fix for the problem but in fact works
    pretty well, allowing many more packages to build OK. I an also
    testing a more sophisticated approach, but this is definitely better
    than just bailing, which often needlessly causes a build to fail.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Makes sense for now at least, yes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-09-14 15:36:22 +0000
3+++ debian/changelog 2011-09-15 16:10:32 +0000
4@@ -21,6 +21,7 @@
5 * Depend on multiarch-capable dpkg-cross and invoke it with
6 --convert-multiarch
7 * Fix lintian test whinge
8+ * Don't fail if null dpkg-cross packages are found LP: #731079
9
10 [ Steve McIntyre ]
11 * Add initial support for armhf
12
13=== modified file 'xdeb.py'
14--- xdeb.py 2011-06-23 00:12:49 +0000
15+++ xdeb.py 2011-09-15 16:10:32 +0000
16@@ -473,7 +473,7 @@
17
18 crossed_debs = []
19 if crossable_debs:
20- convert = ['dpkg-cross', '-a', options.architecture, '-M', '-b']
21+ convert = ['dpkg-cross', '-a', options.architecture, '-A', '-M', '-b']
22 for dep in exclude_deps:
23 convert.extend(('-X', dep))
24 convert.extend(crossable_debs)

Subscribers

People subscribed via source and target branches