Merge lp:~wmills/ubuntu/lucid/gnome-terminal/proxy-wget-fix into lp:ubuntu/lucid/gnome-terminal

Proposed by Bill Mills
Status: Merged
Merge reported by: Daniel Holbach
Merged at revision: not available
Proposed branch: lp:~wmills/ubuntu/lucid/gnome-terminal/proxy-wget-fix
Merge into: lp:ubuntu/lucid/gnome-terminal
Diff against target: 34 lines (+10/-1)
2 files modified
debian/changelog (+8/-0)
src/terminal-screen.c (+2/-1)
To merge this branch: bzr merge lp:~wmills/ubuntu/lucid/gnome-terminal/proxy-wget-fix
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+28005@code.launchpad.net

Description of the change

Fix to not add a trailing comma on no_proxy env var
This fixes one of the lucid specific issues for LP #232469

[Pardon me if this is jumping the gun. I don't know the process but I figure if this is too early you will let me know.]

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

It looks like the this was fixed as part of bug 534225.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-03-23 21:41:22 +0000
3+++ debian/changelog 2010-06-19 23:22:24 +0000
4@@ -1,3 +1,11 @@
5+gnome-terminal (2.29.6-0ubuntu6) lucid; urgency=low
6+
7+ * Don't add a trailing comma to the no_proxy env variable
8+ It messes up wget (and everything that uses it like apt, etc)
9+ This fixes one of the lucid specific issues discussed in LP #232469
10+
11+ -- Bill Mills <wm.a.mills@gmail.com> Sat, 19 Jun 2010 18:33:04 -0400
12+
13 gnome-terminal (2.29.6-0ubuntu5) lucid; urgency=low
14
15 * Revert the previous changes to add a new profile, as changing
16
17=== modified file 'src/terminal-screen.c'
18--- src/terminal-screen.c 2010-02-03 21:03:37 +0000
19+++ src/terminal-screen.c 2010-06-19 23:22:24 +0000
20@@ -1431,12 +1431,13 @@
21 GSList *old;
22
23 g_string_append (buf, ignore->data);
24- g_string_append_c (buf, ',');
25
26 old = ignore;
27 ignore = g_slist_next (ignore);
28 g_free (old->data);
29 g_slist_free_1 (old);
30+ if (ignore != NULL)
31+ g_string_append_c (buf, ',');
32 }
33 set_proxy_env (env_table, "no_proxy", g_string_free (buf, FALSE));
34 }

Subscribers

People subscribed via source and target branches

to status/vote changes: