lp:~wlxing/ecryptfs/lp1695767
Reproduce case:
1) User doesn't install openssl.
2) Run ecryptfs-manager and make selection 3.
It goes in the infinite loop...which means whatever selection you enter next cannot end this command or alter your option.
Reasons:
1) User doesn't install openssl module.
2) The developers of ecryptfs-manager doesn't take such case into consideration.
Hints in code:
Please look at src/libecryptfs
It will prompt user to enter the selection which is set to "val" variable and then run into "else" portion instead of "if" portion. However, "node->
Explanation for the patch:
Adding several lines to take such a case into consideration, through testing whether "num_transitions" is set to zero or not we could prevent the infinite loop. If it is set to zero, it will return -EINVAL because "num_transitions" means how many options this command could show to users and zero means that user has no option to choose.
Any suggestions are welcome :)
- Get this branch:
- bzr branch lp:~wlxing/ecryptfs/lp1695767
Branch merges
- Tyler Hicks: Approve
- Jason Xing (community): Needs Resubmitting
-
Diff: 15 lines (+5/-0)1 file modifiedsrc/libecryptfs/decision_graph.c (+5/-0)
Related bugs
Related blueprints
Branch information
Recent revisions
- 888. By Jason Xing
-
Reproduce case:
1) User doesn't install openssl.
2) Run ecryptfs-manager and make selection 3.
It goes in the infinite loop...which means whatever selection you enter next cannot end this command or alter your option.Explanation for the patch:
Adding several lines to take such a case into consideration, through testing whether "num_transitions" is set to zero or not we could prevent the infinite loop. If it is set to zero, it will return -EINVAL because "num_transitions" means how many options this command could show to users and zero means that user has no option to choose. (LP: #1695767) - 886. By Jason Xing
-
libecryptfs: Handle '=' characters in mount option string values
Users cannot mount ecryptfs with "-o passphrase_
passwd_ file=mykey" (<mykey> is
"passwd=123=abc") or "-o passwd=123=abc". Because the passphrase user uses
includes "=" character.Because in the manner of process_comma_tok() function, ecryptfs will store
"passwd=123" as the @current->name and "abc" as @current->value. That will go
wrong when we go into tf_pass_file() function because it cannot match the name
"passphrase_passwd" or "passwd".Add two lines in process_comma_tok() to change that case. If we match one "="
character in the string, we don't need to loop and match another "=" again. - 884. By Tyler Hicks
-
debian/
ecryptfs- utils.postinst: Fix any unencrypted GPT swap partitions
that have mistakenly remained marked as auto mount. This should only
modify the swap partitions on systems that ecryptfs-setup-swap has been
used on. (LP: #1447282, LP: #1597154) - 883. By Tyler Hicks
-
tests/kernel/
lp-872905. sh: Adjust the test to account for upstream kernel
changes that were preventing the test from cleaning up after itself. The kernel
had a change of behavior where mounts that are configured to use encrypted
filenames will not be able to successfully lookup lower files with plaintext
filenames. This change caused the lower filler file, which was being created
directly in the lower filesystem, to not be removed during the test cleanup and
all of the following tests to fail since the lower filesystem remained full.The upstream kernel commit mentioned above is:
88ae4ab ecryptfs_lookup(): try either only encrypted or plaintext name
- 882. By Tyler Hicks
-
src/utils/
ecryptfs- setup-swap: Prevent unencrypted swap partitions from
being automatically enabled by systemd. This bug affected GPT partitioned
NVMe/MMC drives and resulted in the swap partition being used without
encryption. It also resulted in a usability issue in that users were
erroneously prompted to enter a pass-phrase to unlock their swap partition
at boot. (LP: #1597154) - 881. By Tyler Hicks
-
[ Richard Laager ]
* src/utils/ecryptfs- setup-private: LP: #1574174
- Adjust the test for discovering already active mount point destinations
so that it doesn't accidentally match mount point sources.
- Fixes ecryptfs-setup-private issue when attempting to use ZFS and
eCryptfs together
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:ecryptfs