Code review comment for lp:~wligtenberg/django-openid-auth/mysql_fix

Revision history for this message
Dave Walker (davewalker) wrote :

When i've deployed this on mysql backed django applications, I have encountered the same thing and used the fix as proposed in the merge. However, I haven't tested this fix on postgres or sqlite.

The only thing I would say, the "claimed_id" stores the value returned from the provider. The standard launchpad value is something like:
https://login.launchpad.net/+id/XXXXXXX

This is 39 chars. Is it conceivable that a different provider might use a URL longer than 255 chars?

RFC2616 Does hint a recommendation of limiting to 255 bytes - but URL's of >2000 are also popular and supported.

« Back to merge proposal