Code review comment for lp:~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink

Revision history for this message
Paul Catinean (wiz-keed) wrote :

Apologies, I have replied in the email client instead of writing comments here:

1st reply @rvalyi:

Glad to help out!

A local test showed no impact on a database that already had boms and mrp.subproducts created, automated tests would be more tedious instead of my isolated case though

2nd reply @pedro.baeza:

I kinda feel the same way to be honest since it's not a constraint that might be blocked by preexisting records.It will only affect delete statements after it has been placed on the table, and local tests show no problems

Up to you guys, cheers!

« Back to merge proposal