Merge lp:~wingpanel-devs/wingpanel-indicator-datetime/weekday_uppercase into lp:~wingpanel-devs/wingpanel-indicator-datetime/trunk

[Djax]

ensure that the first letter of the weekday on the top is always upper case

In some languages e.g. french the first letter of the week day is not in upper case. This makes sure that the weekday on the top starts with a upper case letter.

[kay van der Zander (kay20)]

Just a question why aren't you using the up and down functions of string in glib?

If you want to have al characters lowercase then use down function is way shorter then convert one char into lowercase.

As far as i understand what you are achieving is "Monday" into "monday" right?

review: Needs Information

[Djax (parnold-x)]

Nope, like the description says.
It does "monday" to "Monday"

[kay van der Zander (kay20)]

String format = formated_weekday.get_char(0).totitle/toupper().to_string();
format += fomated_weekday.substring (1, -1);

How about this way? Filling the string from right to left.

[Zisu Andrei (matzipan)]

I do not see any regressions.

review: Approve

=== modified file 'src/Indicator.vala'
--- src/Indicator.vala	2016-02-06 17:07:46 +0000
+++ src/Indicator.vala	2016-02-12 21:18:14 +0000
@@ -137,7 +137,10 @@
     }
 
     private void update_today_button () {
-        weekday_label.set_label (Services.TimeManager.get_default ().format ("%A"));
+        string formated_weekday = Services.TimeManager.get_default ().format ("%A");
+        string new_value = formated_weekday.substring (formated_weekday.index_of_nth_char (1));
+        new_value = formated_weekday.get_char (0).totitle ().to_string () + new_value;
+        weekday_label.set_label (new_value);
         /* TRANSLATORS: Date format in the popover excluding the weekday; following http://valadoc.org/#!api=glib-2.0/GLib.DateTime.format */
         date_label.set_label (Services.TimeManager.get_default ().format (_("%B %e, %Y")));
     }