Code review comment for lp:~wingpanel-devs/audience/sound-indicator-in-fullscreen

Viko Adi Rahmawan (vikoadi) wrote :

otherwise i still think depending on wingpanel is a bad move as the dependency will be coupled together. if i want to have audience, then i need wingpanel, then wingpanel need gala, then gala need plank. i would go for minimum dependency as possible espessially if it only use in small portion of apps.
to overcome code duplication, if we can upload a stable indicator-sound tar.gz, we can script cmake to download and extract those tar.gz then we can simply include the class we want. of course its depend on how loosely sound indicator class

« Back to merge proposal