Code review comment for lp:~wiml-omni/libdrizzle/date-time

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

So, there are two problems that flagged up when trying to merge this. I don't quite see how they are related to this branch yet, but:

Ubuntu 12.04:

../tests/unit/numbers.c:307: main Assertion 'FLOAT_EQ_EXACT(col_dblval, expect_dblval)' [ Floating-point values 291.000000 != 291.271111 (difference is -0.271111) ]
Row 1
  Column 2: 1 "1" 1.000000
  Column 3: 1 "1" 1.000000
  Column 4: 1 "1" 1.000000
  Column 5: 1 "1" 1.000000
  Column 6: 1 "1" 1.000000
  Column 7: 1 "1.000000" 1.000000
  Column 8: 1 "1.000000" 1.000000
Row 2
  Column 2: 127 "127" 127.000000
  Column 3: 32687 "32687" 32687.000000
  Column 4: 8388351 "8388351" 8388351.000000
  Column 5: 2147352575 "2147352575" 2147352575.000000
  Column 6: 9222246136947920895 "9222246136947920895" 9222246136947920896.000000
  Column 7: 443664 "443664.000000" 443664.000000
FAIL: tests/unit/numbers

Fedora 17:
/usr/bin/ld: tests/unit/numbers.o: undefined reference to symbol 'truncf@@GLIBC_2.2.5'
/usr/bin/ld: note: 'truncf@@GLIBC_2.2.5' is defined in DSO /lib64/libm.so.6 so try adding it to the linker command line
/lib64/libm.so.6: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
make[1]: *** [tests/unit/numbers] Error 1

I'll look into these later this evening.

« Back to merge proposal