Merge lp:~willcooke/ubuntu-themes/ubuntu-themes-linkedbuttons into lp:ubuntu-themes

Proposed by Will Cooke
Status: Merged
Approved by: Iain Lane
Approved revision: 468
Merged at revision: 468
Proposed branch: lp:~willcooke/ubuntu-themes/ubuntu-themes-linkedbuttons
Merge into: lp:ubuntu-themes
Diff against target: 35 lines (+14/-0)
2 files modified
Ambiance/gtk-3.0/gtk-widgets.css (+7/-0)
Radiance/gtk-3.0/gtk-widgets.css (+7/-0)
To merge this branch: bzr merge lp:~willcooke/ubuntu-themes/ubuntu-themes-linkedbuttons
Reviewer Review Type Date Requested Status
Iain Lane Pending
Review via email: mp+289967@code.launchpad.net

Commit message

Override box shadow and border settings for linked dialog buttons so they don't looked mashed together.
Extra border radius is required to stop the button background bleeding through the border.

Description of the change

Override box shadow and border settings for linked dialog buttons so they don't looked mashed together.
Extra border radius is required to stop the button background bleeding through the border.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

I think it's okay, but out of interest why did you try to make them look un-linked instead of making them look good and linked?

Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

I don’t know what is this branch trying to achieve. The linked buttons now look worse!

Revision history for this message
Iain Lane (laney) wrote :

On Fri, Apr 15, 2016 at 09:06:17AM -0000, Adolfo Jayme wrote:
> I don’t know what is this branch trying to achieve. The linked buttons now look worse!

Definitely not.

But if you want to come up with a better fix (to use the linked style,
as per Adwaita and/or Greybird), then please do.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.0/gtk-widgets.css'
2--- Ambiance/gtk-3.0/gtk-widgets.css 2016-01-20 12:04:47 +0000
3+++ Ambiance/gtk-3.0/gtk-widgets.css 2016-03-23 19:47:01 +0000
4@@ -265,6 +265,13 @@
5 box-shadow: none;
6 }
7
8+/* Make linked dialog buttons look like they are not linked */
9+.message-dialog .linked.dialog-action-area .button {
10+ border-image-width: 12px;
11+ box-shadow: none;
12+ border-radius: 7px;
13+}
14+
15 /****************
16 * cell and row *
17 ****************/
18
19=== modified file 'Radiance/gtk-3.0/gtk-widgets.css'
20--- Radiance/gtk-3.0/gtk-widgets.css 2016-01-20 12:04:47 +0000
21+++ Radiance/gtk-3.0/gtk-widgets.css 2016-03-23 19:47:01 +0000
22@@ -286,6 +286,13 @@
23 box-shadow: none;
24 }
25
26+/* Make linked dialog buttons look like they are not linked */
27+.message-dialog .linked.dialog-action-area .button {
28+ border-image-width: 12px;
29+ box-shadow: none;
30+ border-radius: 7px;
31+}
32+
33 /****************
34 * cell and row *
35 ****************/

Subscribers

People subscribed via source and target branches