Code review comment for lp:~willcooke/gdm/ubuntu

Should that rm be as part of purge, or for everything? i.e. do I put it in
the "if [ $1 = "purge" ]" section, or just at the end of the script?

On 13 July 2017 at 12:42, Daniel van Vugt <email address hidden>
wrote:

> Review: Approve
>
> I think this branch is the best option for the time being. The Arch wiki
> recommends a similar workaround, and upstream PulseAudio acknowledges it
> could do better:
> https://bugs.freedesktop.org/show_bug.cgi?id=98144
> But fixing that will take a lot more time and Pulse internals expertise.
>
> As for the a11y concern, while valid I think that fails to consider the
> fact that the bug being fixed here is a much bigger than a11y. All
> Bluetooth audio users won't have any audio. So that is logically a bigger
> target audience than a11y users who rely on Bluetooth.
>
> Only one minor issue I think: There is no uninstall/postrm step to wind
> back /var/lib/gdm3/.config/pulse/default.pa
> --
> https://code.launchpad.net/~willcooke/gdm/ubuntu/+merge/327165
> You are the owner of lp:~willcooke/gdm/ubuntu.
>