Merge lp:~widelands-dev/widelands/valgrind into lp:widelands
Proposed by
GunChleoc
Status: | Merged |
---|---|
Merged at revision: | 9013 |
Proposed branch: | lp:~widelands-dev/widelands/valgrind |
Merge into: | lp:widelands |
Diff against target: |
99 lines (+56/-0) 3 files modified
src/ai/defaultai.cc (+1/-0) src/wui/building_statistics_menu.cc (+5/-0) valgrind.supp (+50/-0) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands/valgrind |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Klaus Halfmann | code review | Approve | |
Review via email: mp+364213@code.launchpad.net |
Commit message
Update Valgrind suppressions and fix uninitialized variables reported by Valgrind Memcheck
- Uninitialized variable in default AI
- Uninitialized variables in Building Statistics
- Exclude more errors from zip filesystem, Eris and graphics drivers
Description of the change
I used Valgrind to have a look at memory errors caused by Widelands code. Found a few uninitialized variables. Our code seems to be pretty clean already thanks to ASan :)
To post a comment you must log in.
Code looks fine, will not do any further tests.