Code review comment for lp:~widelands-dev/widelands/toolbar-dropdown-menus

Running tests locally I get (on OSX):

FAIL: test_buttons_property: [string "scripting/ui.lua"]:26: 'nil' not expected!

FAIL: test_name: [string "scripting/ui.lua"]:113: attempt to index a nil value (field 'b')
stack traceback:
 [string "scripting/ui.lua"]:113: in upvalue 'func'
 [string "scripting/lunit.lua"]:425: in function <[string "scripting/lunit.lua"]:425>
 [C]: in global 'xpcall'
 [string "scripting/lunit.lua"]:425: in upvalue 'call'
 [string "scripting/lunit.lua"]:450: in local 'run'
 [string "scripting/lunit.lua"]:476: in global 'lunit_run_testcase'
 [string "scripting/lunit.lua"]:382: in method 'run'
 [string "scripting/init.lua"]:70: in main chunk

FAIL: test_click: [string "scripting/ui.lua"]:116: attempt to index a nil value (field 'b')
stack traceback:
 [string "scripting/ui.lua"]:116: in upvalue 'func'
 [string "scripting/lunit.lua"]:425: in function <[string "scripting/lunit.lua"]:425>
 [C]: in global 'xpcall'
 [string "scripting/lunit.lua"]:425: in upvalue 'call'
 [string "scripting/lunit.lua"]:450: in local 'run'
 [string "scripting/lunit.lua"]:476: in global 'lunit_run_testcase'
 [string "scripting/lunit.lua"]:382: in method 'run'
 [string "scripting/init.lua"]:70: in main chunk

FAIL: test/maps/ship_transportation.wmf/scripting/test_rip_ship_before_picking_up_transporting_ware.lua

...

Fatal exception: [../src/io/filesystem/layered_filesystem.cc:216] LayeredFileSystem: unable to create sub filesystem for existing directory: /var/folders/bx/q32c1w1965g5clyfbfdykcb40000gp/T/widelands_regression_testfmUxCa/save/0_before_removing_ship.wgf
I have tried the following path(s):
    /var/folders/bx/q32c1w1965g5clyfbfdykcb40000gp/T/widelands_regression_testfmUxCa//var/folders/bx/q32c1w1965g5clyfbfdykcb40000gp/T/widelands_regression_testfmUxCa/save/0_before_removing_ship.wgf
    /Users/klaus/develop/widelands-repo/toolbar-dropdown-menus//var/folders/bx/q32c1w1965
FATAL ERROR - game crashed. Attempting emergency save.
lastserial: 0

Caught exception (of type '10WException') in outermost handler!
The exception said: [../src/io/filesystem/layered_filesystem.cc:216] LayeredFileSystem: unable to create sub filesystem for existing directory: /var/folders/bx/q32c1w1965g5clyfbfdykcb40000gp/T/widelands_regression_testfmUxCa/save/0_before_removing_ship.wgf
I have tried the following path(s):
    /var/folders/bx/q32c1w1965g5clyfbfdykcb40000gp/T/widelands_regression_testfmUxCa//var/folders/bx/q32c1w1965g5clyfbfdykcb40000gp/T/widelands_regression_testfmUxCa/save/0_before_removing_ship.wgf
    /Users/klaus/develop/widelands-repo/toolbar-dropdown-menus//var/folders/bx/q32c1w1965

This should not happen. Please file a bug report on version bzr9123[toolbar-dropdown-menus](Release).
and remember to specify your operating system.

----------------------------------------------------------------------
Ran 45 tests in 978.544s

FAILED (failures=2)

Gun: As you are "busy indexing nil values" you may have an idea what happend here ;-)

WIll it help if I:
a) Dig into the test and find what failed?
b) run these tests on linux?

I will no play a normala, single player game for a while and then try again with the debug build