Merge lp:~widelands-dev/widelands/reset_zoom_button into lp:widelands

Proposed by kaputtnik
Status: Merged
Merged at revision: 8261
Proposed branch: lp:~widelands-dev/widelands/reset_zoom_button
Merge into: lp:widelands
Diff against target: 2 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~widelands-dev/widelands/reset_zoom_button
Reviewer Review Type Date Requested Status
GunChleoc Approve
kaputtnik (community) Needs Resubmitting
Review via email: mp+313058@code.launchpad.net

Commit message

modified reset_zoom_button

Description of the change

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1764. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/183353560.
Appveyor build 1603. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_reset_zoom_button-1603.

Revision history for this message
GunChleoc (gunchleoc) wrote :

The looking glass doesn't look round - that effect is probably caused by the shading.

Revision history for this message
TiborB (tiborb95) wrote :

If you zoom closely, right side of magnifier is cut

Revision history for this message
GunChleoc (gunchleoc) wrote :

For inspiration:

http://www.accessfirefox.org/Page_Zoom_Buttons.php

I would like to expand the menu to have +/- buttons as well, so we will need to make sure to keep a layered version of the icon around.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Bunnybot encountered an error while working on this merge proposal:

('The read operation timed out',)

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1764. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/183353560.
Appveyor build 1603. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_reset_zoom_button-1603.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Bunnybot encountered an error while working on this merge proposal:

('The read operation timed out',)

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1764. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/183353560.
Appveyor build 1603. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_reset_zoom_button-1603.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Bunnybot encountered an error while working on this merge proposal:

HTTP Error 500: Internal Server Error

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1764. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/183353560.
Appveyor build 1603. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_reset_zoom_button-1603.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Bunnybot encountered an error while working on this merge proposal:

('The read operation timed out',)

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1764. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/183353560.
Appveyor build 1603. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_reset_zoom_button-1603.

Revision history for this message
kaputtnik (franku) wrote :
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1764. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/183353560.
Appveyor build 1603. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_reset_zoom_button-1603.

Revision history for this message
kaputtnik (franku) wrote :

I have tried to get more sharpen "x1", and provide three alternatives: "x1", "1x" and placing the chars outside the magnifier. The right Magnifier is also better rounded, so depending on what we want to have i use this version of magnifier glass.

https://launchpadlibrarian.net/303212200/reset_zoom_3.png

Revision history for this message
GunChleoc (gunchleoc) wrote :

I think x1 looks most balanced.

Revision history for this message
kaputtnik (franku) wrote :

I think this good now. I push also the gimp xcf file to the media repo.

review: Needs Resubmitting
Revision history for this message
GunChleoc (gunchleoc) wrote :

Perfect :)

@bunnybot merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/images/wui/menus/menu_reset_zoom.png'
2Binary files data/images/wui/menus/menu_reset_zoom.png 2016-10-24 21:23:30 +0000 and data/images/wui/menus/menu_reset_zoom.png 2017-01-25 08:11:51 +0000 differ

Subscribers

People subscribed via source and target branches

to status/vote changes: