Code review comment for lp:~widelands-dev/widelands/reed-compatibility

Revision history for this message
Notabilis (notabilis27) wrote :

So ... you created a diff of 800 lines by passing objects around so you can call a method in only a handful of places?? I like it! :)
The changes are mostly looking good to me. Replacing the GOTO might be broken, though, see my diff comment below.

I haven't tested the changes, mostly because I have no sensible idea how to do so. But based on the code I guess it shouldn't break anything.

« Back to merge proposal