Code review comment for lp:~widelands-dev/widelands/per-level-soldier-anims

Revision history for this message
GunChleoc (gunchleoc) wrote :

I'm not sure that this operator is correct:

        bool operator<(const SoldierLevelRange& other) const {
                return max_health < other.min_health &&
                       max_attack < other.min_attack &&
                       max_defense < other.min_defense &&
                       max_evade < other.min_evade;
        }

For example, what if the range is identical except for health?

« Back to merge proposal