Code review comment for lp:~widelands-dev/widelands/new-shipping

Revision history for this message
Benedikt Straub (nordfriese) wrote :

The OPtr is just a wrapper for a MapObject. I use OPtr<PortDock> rather than PortDock* to avoid segfaults when the portdock is destroyed. The == comparison compares serials, so it´s 100% safe to use.
I found a potential cause for this assert in the way superfluous or invalid destinations are discarded, please check whether you can still reproduce it now…

« Back to merge proposal