Code review comment for lp:~widelands-dev/widelands/net-boost-asio

Revision history for this message
Notabilis (notabilis27) wrote :

Thanks for testing and the review. I fixed all your nits except the iterator. A foreach-loop would not work since I need it to get the key of the std::map and also since I am modifying the map while running through it. The temporary key-variable (for it->first) could be probably removed when I write code like "it++->first". But I at least prefer the better readable version with the variable.

I will give Bunnybot another chance to run, then this will go in.

« Back to merge proposal