Code review comment for lp:~widelands-dev/widelands/multiplayer_dropdowns_2_init_team

Revision history for this message
SirVer (sirver) wrote :

Please revert the macros cast_unsigned and cast_signed and stick to using the static_cast<> operators - they are verbose, but are understood by any c++ programmer without additional context. Code is only written once, but read multiple times - so optimizing for the convenience of the writer is the wrong thing to optimize for.

Otherwise code LGTM and compiles. Not tested.

review: Needs Fixing

« Back to merge proposal