Merge lp:~widelands-dev/widelands/io-dependency-fix into lp:widelands

Proposed by Arty
Status: Merged
Merged at revision: 8937
Proposed branch: lp:~widelands-dev/widelands/io-dependency-fix
Merge into: lp:widelands
Diff against target: 37 lines (+0/-4)
3 files modified
src/io/filesystem/CMakeLists.txt (+0/-1)
src/io/filesystem/disk_filesystem.cc (+0/-1)
src/io/filesystem/layered_filesystem.cc (+0/-2)
To merge this branch: bzr merge lp:~widelands-dev/widelands/io-dependency-fix
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+359658@code.launchpad.net

Commit message

Remove a few superfluous includes which also breaks a small dependency cycle

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4301. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/460550561.
Appveyor build 4094. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_io_dependency_fix-4094.

Revision history for this message
kaputtnik (franku) wrote :

Can you please set a 'Commit Message' to the merge proposal? This is used by bunnybot when merging into trunk :-)

Revision history for this message
GunChleoc (gunchleoc) wrote :

LGTM :)

@bunnybot merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/io/filesystem/CMakeLists.txt'
2--- src/io/filesystem/CMakeLists.txt 2018-05-16 13:51:48 +0000
3+++ src/io/filesystem/CMakeLists.txt 2018-11-27 23:29:05 +0000
4@@ -18,7 +18,6 @@
5 base_log
6 base_macros
7 graphic_text_layout
8- io_fileread
9 io_stream
10 third_party_minizip
11 )
12
13=== modified file 'src/io/filesystem/disk_filesystem.cc'
14--- src/io/filesystem/disk_filesystem.cc 2018-11-14 10:14:50 +0000
15+++ src/io/filesystem/disk_filesystem.cc 2018-11-27 23:29:05 +0000
16@@ -41,7 +41,6 @@
17 #include <unistd.h>
18 #endif
19
20-#include "base/log.h"
21 #include "base/macros.h"
22 #include "base/wexception.h"
23 #include "io/filesystem/filesystem_exceptions.h"
24
25=== modified file 'src/io/filesystem/layered_filesystem.cc'
26--- src/io/filesystem/layered_filesystem.cc 2018-05-17 05:01:45 +0000
27+++ src/io/filesystem/layered_filesystem.cc 2018-11-27 23:29:05 +0000
28@@ -22,9 +22,7 @@
29 #include <cstdio>
30 #include <memory>
31
32-#include "base/log.h"
33 #include "base/wexception.h"
34-#include "io/fileread.h"
35 #include "io/streamread.h"
36
37 LayeredFileSystem* g_fs;

Subscribers

People subscribed via source and target branches

to status/vote changes: