lp:~widelands-dev/widelands/handling-various-fs-errors

Branch merges

Propose for merging

Merged into lp:widelands at revision 8929

GunChleoc: Approve on 2018-11-23

Diff: 512 lines (+213/-44)

9 files modified

src/editor/ui_menus/main_menu_save_map.cc (+39/-10)
src/editor/ui_menus/main_menu_save_map_make_directory.cc (+34/-5)
src/editor/ui_menus/main_menu_save_map_make_directory.h (+3/-0)
src/logic/game.cc (+7/-1)
src/logic/map.cc (+13/-9)
src/network/gameclient.cc (+25/-6)
src/ui_fsmenu/loadgame.cc (+2/-1)
src/wui/load_or_save_game.cc (+83/-11)
src/wui/load_or_save_game.h (+7/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1798816: Replay menu does not respect Show filenames after deleting a replay

Low

Fix Released

Link a bug report

Related blueprints

8904. By artydent on 2018-11-19

in map save menu:
- when making a directory failed only because a file/dir with that name already existed, then the make directory dialogue is reopened immediately (focussed on the edit box and with the same name in it)
- make directory dialogue can now be canceled by pressing Escape

8903. By artydent on 2018-11-15

small fixes

8902. By artydent on 2018-11-14

merged trunk

8901. By artydent on 2018-11-14

compliance to style guide

8900. By artydent on 2018-11-08

In Load/Save menu for games/replays:
- All deletion errors are caught, player gets a message.
- When deleting multiplayer replays, also the corresponding syncstream file is deleted.
- After deleting replays, the table now respects the Show Filenames setting.

In Save menu for maps:
- Errors when trying to create a directory are now caught, player gets a message.
- Directory creation now doesn't allow names with map extensions, because the game would just trying to interpret them as maps and not show as directories. A tooltip is shown.
- Directory creation can now also be triggered by pressing Enter in the name edit box.

Other file errors are caught and logged:
- syncstream deletion in SyncWrapper destructor
- in Map::get_correct_loader
- file deletion/renaming in GameClient::handle_packet

8899. By artydent on 2018-11-04

made codecheck happy

8898. By artydent on 2018-11-01

- some filesystem errorchecking added
- more specific filesystem exceptions thrown

8897. By artydent on 2018-11-01

Merged trunk.

8896. By artydent on 2018-10-21

Whenever a map is fully loaded (editor/game/replay) the map is immediately saved to a temp file and the map's filesystem is reassigned to that temp file in a special directory. So when map/save files are handled anywhere, there won't be any filesystem conflicts with or even accidentally deletion of the map filesystem (which would lead to corrupt save files later).

Temp files are automatically deleted when not needed anymore.

Upon application start, any found temp files that are older than a week are considered accidental leftovers (e.g. from crashes) and deleted.

8895. By Wideland's Bunnybot <email address hidden> on 2018-10-20

Merged lp:~widelands-dev/widelands/frisian-buildings:
Improved graphics for the frisian sentinel