Merge lp:~widelands-dev/widelands/frisians_string_fixes into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 8644
Proposed branch: lp:~widelands-dev/widelands/frisians_string_fixes
Merge into: lp:widelands
Diff against target: 136 lines (+18/-18)
6 files modified
data/campaigns/fri01.wmf/scripting/texts.lua (+2/-2)
data/tribes/buildings/partially_finished/dismantlesite/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/blacksmithy/init.lua (+10/-10)
data/tribes/buildings/productionsites/frisians/charcoal_kiln/init.lua (+2/-2)
data/tribes/buildings/productionsites/frisians/well/init.lua (+2/-2)
data/txts/tips/frisians.lua (+1/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands/frisians_string_fixes
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+342702@code.launchpad.net

Commit message

Fixed typos and string consistency issues, mostly for the Frisians.

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 3343. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/362480961.
Appveyor build 3149. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_frisians_string_fixes-3149.

Revision history for this message
Benedikt Straub (nordfriese) wrote :

Looks good to me, one diff comment

Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks, I had missed that one.

@bunnybot merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/campaigns/fri01.wmf/scripting/texts.lua'
2--- data/campaigns/fri01.wmf/scripting/texts.lua 2018-03-11 15:55:43 +0000
3+++ data/campaigns/fri01.wmf/scripting/texts.lua 2018-04-06 06:33:33 +0000
4@@ -98,7 +98,7 @@
5 title=_"Train your soldiers",
6 number = 1,
7 body = objective_text(_"Training Soldiers",
8- li(_[[Train a soldier to the highest possible level. Soldiers are trained in small training camps and large training arenas. We will need a gold mine, a tailor’s shop to sew better armor, and a large armor smithy for better weapons and helmets.]])
9+ li(_[[Train a soldier to the highest possible level. Soldiers are trained in training camps and training arenas. We will need a gold mine, a tailor’s shop to sew better armor, and a large armor smithy for better weapons and helmets.]])
10 ),
11 }
12 obj_defeat_enemy = {
13@@ -312,7 +312,7 @@
14 _([[We are recruiting soldiers easily enough, but they are fairly weak. We must train our soldiers if they are to beat the enemy.]])
15 .. paragraphdivider() ..
16 -- TRANSLATORS: Reebaud – train soldiers 1
17- _([[Soldiers are trained in basic attack, health and defense by a small training camp. They can learn the finer points in a large training arena.]])),
18+ _([[Soldiers are trained in basic attack, health and defense by a training camp. They can learn the finer points in a training arena.]])),
19 }
20 training_2 = {
21 title =_ "Training Soldiers",
22
23=== modified file 'data/tribes/buildings/partially_finished/dismantlesite/helptexts.lua'
24--- data/tribes/buildings/partially_finished/dismantlesite/helptexts.lua 2016-10-18 07:10:54 +0000
25+++ data/tribes/buildings/partially_finished/dismantlesite/helptexts.lua 2018-04-06 06:33:33 +0000
26@@ -13,7 +13,7 @@
27
28 function building_helptext_purpose()
29 -- TRANSLATORS: Purpose helptext for a building
30- return pgettext("building", "A building is being dismantled at this dismantlesite, returning some of the resources that were used during this building’s construction to your tribe’s stores.")
31+ return pgettext("building", "A building is being dismantled at this dismantle site, returning some of the resources that were used during this building’s construction to your tribe’s stores.")
32 end
33
34 function building_helptext_note()
35
36=== modified file 'data/tribes/buildings/productionsites/frisians/blacksmithy/init.lua'
37--- data/tribes/buildings/productionsites/frisians/blacksmithy/init.lua 2018-02-13 14:26:22 +0000
38+++ data/tribes/buildings/productionsites/frisians/blacksmithy/init.lua 2018-04-06 06:33:33 +0000
39@@ -112,8 +112,8 @@
40 },
41 },
42 produce_3 = {
43- -- TRANSLATORS: Completed/Skipped/Did not start forging a scythe because ...
44- descname = _"forging a scythe",
45+ -- TRANSLATORS: Completed/Skipped/Did not start making a scythe because ...
46+ descname = _"making a scythe",
47 actions = {
48 "return=skipped unless economy needs scythe",
49 "sleep=32000",
50@@ -123,8 +123,8 @@
51 },
52 },
53 produce_4 = {
54- -- TRANSLATORS: Completed/Skipped/Did not start forging a shovel because ...
55- descname = _"forging a shovel",
56+ -- TRANSLATORS: Completed/Skipped/Did not start making a shovel because ...
57+ descname = _"making a shovel",
58 actions = {
59 "return=skipped unless economy needs shovel",
60 "sleep=32000",
61@@ -145,8 +145,8 @@
62 },
63 },
64 produce_6 = {
65- -- TRANSLATORS: Completed/Skipped/Did not start forging a hunting spear because ...
66- descname = _"forging a hunting spear",
67+ -- TRANSLATORS: Completed/Skipped/Did not start making a hunting spear because ...
68+ descname = _"making a hunting spear",
69 actions = {
70 "return=skipped unless economy needs hunting_spear",
71 "sleep=32000",
72@@ -189,8 +189,8 @@
73 },
74 },
75 produce_10 = {
76- -- TRANSLATORS: Completed/Skipped/Did not start forging a hammer because ...
77- descname = _"forging a hammer",
78+ -- TRANSLATORS: Completed/Skipped/Did not start making a hammer because ...
79+ descname = _"making a hammer",
80 actions = {
81 "return=skipped unless economy needs hammer",
82 "sleep=32000",
83@@ -200,8 +200,8 @@
84 },
85 },
86 produce_11 = {
87- -- TRANSLATORS: Completed/Skipped/Did not start forging fire tongs because ...
88- descname = _"forging fire tongs",
89+ -- TRANSLATORS: Completed/Skipped/Did not start making fire tongs because ...
90+ descname = _"making fire tongs",
91 actions = {
92 "return=skipped unless economy needs fire_tongs",
93 "sleep=32000",
94
95=== modified file 'data/tribes/buildings/productionsites/frisians/charcoal_kiln/init.lua'
96--- data/tribes/buildings/productionsites/frisians/charcoal_kiln/init.lua 2018-02-23 07:18:54 +0000
97+++ data/tribes/buildings/productionsites/frisians/charcoal_kiln/init.lua 2018-04-06 06:33:33 +0000
98@@ -57,8 +57,8 @@
99
100 programs = {
101 work = {
102- -- TRANSLATORS: Completed/Skipped/Did not start burning charcoal because ...
103- descname = _"burning charcoal",
104+ -- TRANSLATORS: Completed/Skipped/Did not start producing coal because ...
105+ descname = _"producing coal",
106 actions = {
107 "sleep=30000",
108 "return=skipped unless economy needs coal",
109
110=== modified file 'data/tribes/buildings/productionsites/frisians/well/init.lua'
111--- data/tribes/buildings/productionsites/frisians/well/init.lua 2018-02-16 14:53:04 +0000
112+++ data/tribes/buildings/productionsites/frisians/well/init.lua 2018-04-06 06:33:33 +0000
113@@ -46,8 +46,8 @@
114
115 programs = {
116 work = {
117- -- TRANSLATORS: Completed/Skipped/Did not start mining water because ...
118- descname = _"mining water",
119+ -- TRANSLATORS: Completed/Skipped/Did not start working because ...
120+ descname = _"working",
121 actions = {
122 "sleep=20000",
123 "animate=working 20000",
124
125=== modified file 'data/txts/tips/frisians.lua'
126--- data/txts/tips/frisians.lua 2017-07-07 07:48:20 +0000
127+++ data/txts/tips/frisians.lua 2018-04-06 06:33:33 +0000
128@@ -5,7 +5,7 @@
129 seconds = 9
130 },
131 {
132- text = _"Always build a forester´s house, so you will not run out of logs.",
133+ text = _"Always build a forester’s house, so you will not run out of logs.",
134 seconds = 4
135 },
136 {

Subscribers

People subscribed via source and target branches

to status/vote changes: