Merge lp:~widelands-dev/widelands/fix-language-entry-ms into lp:widelands

Proposed by Arty on 2018-11-10
Status: Merged
Merged at revision: 8918
Proposed branch: lp:~widelands-dev/widelands/fix-language-entry-ms
Merge into: lp:widelands
Diff against target: 15 lines (+2/-2)
1 file modified
data/i18n/locales.lua (+2/-2)
To merge this branch: bzr merge lp:~widelands-dev/widelands/fix-language-entry-ms
Reviewer Review Type Date Requested Status
Widelands Developers 2018-11-10 Pending
Review via email: mp+358597@code.launchpad.net
To post a comment you must log in.
Arty (artydent) wrote :

Disclosure: I actually don't speak the language nor do I know anyone who does.

I only stumbled upon this by accident when I checked RTL stuff and found weird behaviour: The language entry in the options menu was arabic looking and RTL, but all the translations were in Latin script and - even though aligned right (probably because if the font setting) - seemed to be meant for reading left-to-right.

Acording to Google+Wikipedia there still is an arabic script for the language but also Latin one, which is much more widespread and also the official script. And it's not RTL. Given that (as far as I could see) all our existing ms translations use the Latin script, I thought we should change the entry in the lua file, so the options menu shows the Latin name and the alignment is not automatically switched.

bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4207. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/453365089.
Appveyor build 4003. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_language_entry_ms-4003.

GunChleoc (gunchleoc) wrote :

Good spot - we don't have an active translator at the moment for this language. I double-checked on Transifex and all translations are indeed in Latin script.

I have echoed this fix on Transifex so it won't regress with the next translations pull.

@bunnybot merge

bunnybot (widelandsofficial) wrote :

Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways.

Travis build 4207. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/453365089.

GunChleoc (gunchleoc) wrote :

Transient failure on Travis

@bunnybot merge force

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/i18n/locales.lua'
2--- data/i18n/locales.lua 2018-11-10 09:20:09 +0000
3+++ data/i18n/locales.lua 2018-11-10 18:49:34 +0000
4@@ -249,9 +249,9 @@
5 },
6
7 ms = {
8- name = "بهاس ملايو",
9+ name = "Bahasa Melayu",
10 sort_name = "Melayu",
11- font = "arabic"
12+ font = "default"
13 },
14
15 my = {