Merge lp:~widelands-dev/widelands/document_mine into lp:widelands

Proposed by SirVer
Status: Merged
Merged at revision: 8227
Proposed branch: lp:~widelands-dev/widelands/document_mine
Merge into: lp:widelands
Diff against target: 19 lines (+8/-1)
1 file modified
doc/sphinx/source/productionsite_program.rst (+8/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands/document_mine
Reviewer Review Type Date Requested Status
Widelands Developers Pending
Review via email: mp+313509@code.launchpad.net

Commit message

Document the mine command. I read through the code to get to this documentation, I hope it is correct.

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1779. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/185001578.
Appveyor build 1617. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_document_mine-1617.

Revision history for this message
GunChleoc (gunchleoc) wrote :

+1 to more documentation :)

How about adding a small code example to illustrate, and/or turning this into a list? Kaputtnik and I fiddled with the format for this with the (still incomplete) Tribes units and animations:

https://wl.widelands.org/docs/wl/autogen_toc_lua_tribes_buildings/

https://wl.widelands.org/docs/wl/animations/

Revision history for this message
SirVer (sirver) wrote :

I had no intention on working on this further - I just felt that my digging should not go unused. Let's not let the good be the enemy of better.

> Am 19.12.2016 um 11:19 schrieb GunChleoc <email address hidden>:
>
> +1 to more documentation :)
>
> How about adding a small code example to illustrate, and/or turning this into a list? Kaputtnik and I fiddled with the format for this with the (still incomplete) Tribes units and animations:
>
> https://wl.widelands.org/docs/wl/autogen_toc_lua_tribes_buildings/
>
> https://wl.widelands.org/docs/wl/animations/
> --
> https://code.launchpad.net/~widelands-dev/widelands/document_mine/+merge/313509
> Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/document_mine into lp:widelands.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~widelands-dev
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~widelands-dev
> More help : https://help.launchpad.net/ListHelp

Revision history for this message
GunChleoc (gunchleoc) wrote :

OK, let's get the information in then and make it more readable later. I am planning to do more work on the documentation once I have cleared my backlog of branches a bit.

@bunnybot merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/sphinx/source/productionsite_program.rst'
2--- doc/sphinx/source/productionsite_program.rst 2016-03-07 10:28:35 +0000
3+++ doc/sphinx/source/productionsite_program.rst 2016-12-18 21:04:18 +0000
4@@ -186,7 +186,14 @@
5
6 mine
7 ----
8-Takes resources from the ground. This command type is subject to change.
9+Takes resources from the ground. It takes as arguments first the resource
10+name, after this the radius for searching for the resource around the building
11+field. The next values is the percentage of starting resources that can be dug
12+out before this mine is exhausted. The next value is the percentage that this
13+building still produces something even if it is exhausted. And the last value
14+is the percentage chance that a worker is gaining experience on failure - this
15+is to guarantee that you can eventually extend a mine, even though it was
16+exhausted for a while already.
17
18 check_soldier
19 -------------

Subscribers

People subscribed via source and target branches

to status/vote changes: