Merge lp:~widelands-dev/widelands/debian-sdl2-packages into lp:~widelands-dev/widelands/debian

Proposed by Hans Joachim Desserud
Status: Merged
Merged at revision: 25
Proposed branch: lp:~widelands-dev/widelands/debian-sdl2-packages
Merge into: lp:~widelands-dev/widelands/debian
Diff against target: 22 lines (+6/-6)
1 file modified
debian/control (+6/-6)
To merge this branch: bzr merge lp:~widelands-dev/widelands/debian-sdl2-packages
Reviewer Review Type Date Requested Status
SirVer Approve
Review via email: mp+239904@code.launchpad.net

Description of the change

Accompanies https://code.launchpad.net/~widelands-dev/widelands/SDL2/+merge/239865
Needs to be merged at the same time.

Switches the dependencies for our PPA from SDL to SDL2-packages. I also took the liberty to organize them alphabetically.

Built, installed, and ran fine in my test PPA. (https://code.launchpad.net/~hjd/+recipe/widelands-test)

Note that since SDL2 wasn't packaged at the time Ubuntu 12.04 was released, those packages aren't available for that release. So we would either need to find/create a backport similiar to what we did with GCC 4.7, or retire that PPA. I'm partially leaning towards retirement. One thing is using backported GCC for building, but SDL will be needed run-time too. So people on 12.04 would need to get those packages somehow. That is probably possible somehow (I think it is even possible to make one PPA depend on another), though I don't know how much effort we should put into making packages available which doesn't exist in the regular repo. 14.04 has been out for a while, and most likely more people will have migrated to the newer LTS once we make a stable release at some point in the future.

(Before we make a decision though, we should probably take a look at the usage for the 12.04 PPA. While the LP page doesn't show the download counts, it looks like it should be possible through the Launchpad API. Will look into this.)

(Ubuntu 14.04 and later releases have SDL2-packages available and are not affected.)

To post a comment you must log in.
Revision history for this message
SirVer (sirver) wrote :

I believe that we should not need sdl_gfx anymore - we only used it for it's rotozoom implementation - and we did not use the roto part at all, only the zoom part. AFAIK sdl2 has methods for that now build in, so we can loose this dependency which would be nice.

Revision history for this message
SirVer (sirver) :
review: Approve
Revision history for this message
GunChleoc (gunchleoc) wrote :

The rotozoom header is still used in a coulple of files. I have created a new bug for this: https://bugs.launchpad.net/widelands/+bug/1387317

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-10-18 16:28:40 +0000
3+++ debian/control 2014-10-28 19:52:47 +0000
4@@ -7,12 +7,12 @@
5 Enrico Tassi <gareuselesinge@debian.org>
6 Standards-Version: 3.9.5
7 Build-Depends: debhelper (>= 9),
8- libsdl1.2-dev,
9- libsdl-image1.2-dev,
10- libsdl-ttf2.0-dev,
11- libsdl-net1.2-dev,
12- libsdl-mixer1.2-dev,
13- libsdl-gfx1.2-dev,
14+ libsdl2-dev,
15+ libsdl2-gfx-dev,
16+ libsdl2-image-dev,
17+ libsdl2-mixer-dev,
18+ libsdl2-net-dev,
19+ libsdl2-ttf-dev,
20 python,
21 libboost1.48-dev | libboost-dev,
22 libboost-regex1.48-dev | libboost-regex-dev,

Subscribers

People subscribed via source and target branches