Code review comment for lp:~widelands-dev/widelands/constructionsite_options

GunChleoc (gunchleoc) wrote :

OK, let's leave the design as it is :)

This doesn't compile: -c ../src/wui/
In file included from ../src/wui/dismantlesitewindow.h:25:0,
                 from ../src/wui/
../src/wui/buildingwindow.h: In member function ‘void BuildingWindow::set_building_descr_for_help(const Widelands::BuildingDescr&)’:
../src/wui/buildingwindow.h:99:30: error: ‘void Widelands::BuildingDescr::operator=(const Widelands::BuildingDescr&)’ is private within this context
   building_descr_for_help_ = d;

Once that has been fixed, we still need to look at the code.

« Back to merge proposal