Merge lp:~widelands-dev/widelands/bug_1836107_lGL into lp:widelands

Proposed by kaputtnik on 2019-07-18
Status: Merged
Merged at revision: 9165
Proposed branch: lp:~widelands-dev/widelands/bug_1836107_lGL
Merge into: lp:widelands
Diff against target: 34 lines (+3/-3)
2 files modified
CMakeLists.txt (+1/-1)
utils/win32/innosetup/Widelands.iss (+2/-2)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug_1836107_lGL
Reviewer Review Type Date Requested Status
GunChleoc 2019-07-18 Approve on 2019-07-27
Review via email: mp+370334@code.launchpad.net

Commit message

Link GL libraries insted of setting flags.
Fixes appveyor failures due to missing lbpdcurses.dll

Description of the change

See https://bugs.launchpad.net/widelands/+bug/1836107

One should may apply a better commit message ;)

To post a comment you must log in.
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 5272. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/560611605.
Appveyor build 5048. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1836107_lGL-5048.

9166. By kaputtnik on 2019-07-19

replaced lbpdcurses.dll with libtermcap-0.dll

kaputtnik (franku) wrote :
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 5274. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/561026259.
Appveyor build 5050. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1836107_lGL-5050.

kaputtnik (franku) wrote :

Looks good now.

Thanks to Dirk Stöcker for the fix.

I don't think this needs a code review:

@bunnybot merge

GunChleoc (gunchleoc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2019-06-15 09:13:13 +0000
3+++ CMakeLists.txt 2019-07-19 13:17:10 +0000
4@@ -182,7 +182,7 @@
5
6 # This is set to avoid linker errors when using GLVND-libs on Linux
7 if("${OpenGL_GL_PREFERENCE}" STREQUAL "GLVND")
8- set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -lGL")
9+ link_libraries("GL")
10 add_compile_definitions(WL_USE_GLVND)
11 message(STATUS "Adding linker flags for GLVND.")
12 endif()
13
14=== modified file 'utils/win32/innosetup/Widelands.iss'
15--- utils/win32/innosetup/Widelands.iss 2019-06-01 20:53:24 +0000
16+++ utils/win32/innosetup/Widelands.iss 2019-07-19 13:17:10 +0000
17@@ -103,7 +103,7 @@
18 Source: {#BuildFolder}\data\ai\*; DestDir: {app}\data\ai\; Flags: recursesubdirs ignoreversion; Tasks: ; Languages: ; Attribs: hidden; Components: "Widelands"
19 Source: {#DLLFolder}\libopusfile-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
20 Source: {#DLLFolder}\libopus-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
21-Source: {#DLLFolder}\libpdcurses.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
22+Source: {#DLLFolder}\libtermcap-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
23 Source: {#DLLFolder}\libgmodule-2.0-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
24 Source: {#DLLFolder}\libreadline8.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
25 Source: {#DLLFolder}\libicuuc64.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
26@@ -113,7 +113,7 @@
27 Source: {#DLLFolder}\libgcc_s_seh-1.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
28 #else
29 Source: {#DLLFolder}\libgcc_s_dw2-1.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
30-#endif
31+#endif
32 Source: {#DLLFolder}\glew32.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
33 Source: {#DLLFolder}\libglib-2.0-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
34 Source: {#DLLFolder}\libharfbuzz-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"