Merge lp:~widelands-dev/widelands/bug1790456_game_summary into lp:widelands

[hessenfarmer]

fixed the bug 1790456
status and gametime are shown again in game summary window.

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 4082. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/435374102.
Appveyor build 3878. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug1790456_game_summary-3878.

[GunChleoc (gunchleoc)]

Actually, the "time" column is completely superfluous, because it's the same for all players - we're showing the "Elapsed time" on the bottom, that is enough.

I think we should just get rid of it, or will it with the score instead. Then we can fill the "player info" area with more detailed info for Build 21.

[hessenfarmer (stephan-lutz)]

As this bug is targeted for b20, the question is what to do for the moment being?

I would vote for having this in the state as for b19 (that's why I didn't any further changes). And do the changes you proposed for b21.
Otherwise we would have another string to translate and other implications

[hessenfarmer (stephan-lutz)]

BTW time isn't completly superfluous as it shows the player end time - normally this is the total game time for the winner and last opponent but it is different for a player who lost early (i.e. lost it's last headquarters)
From my imagination this might be interesting in multiplayer games, at least it isn't the same information as in the bottom line.

I tested this with this branch.

[GunChleoc (gunchleoc)]

Ah, that's a case I didn't think of. Good catch!

Let's have it then :)

@bunnybot merge

=== modified file 'src/wui/game_summary.cc'
--- src/wui/game_summary.cc	2018-05-31 18:01:27 +0000
+++ src/wui/game_summary.cc	2018-09-30 21:05:46 +0000
@@ -102,7 +102,7 @@
 	players_table_->add_column(150, _("Player"));
 	players_table_->add_column(80, _("Team"), "", UI::Align::kCenter);
 	players_table_->add_column(100, _("Status"), "", UI::Align::kCenter);
-	players_table_->add_column(0, _("Time"), "", UI::Align::kRight, UI::TableColumnType::kFlexible);
+	players_table_->add_column(100, _("Time"), "", UI::Align::kCenter);
 
 	// Prepare Elements
 	title_area_->set_fontsize(UI_FONT_SIZE_BIG);