Merge lp:~widelands-dev/widelands/bug1790456_game_summary into lp:widelands

Proposed by hessenfarmer
Status: Merged
Merged at revision: 8866
Proposed branch: lp:~widelands-dev/widelands/bug1790456_game_summary
Merge into: lp:widelands
Diff against target: 12 lines (+1/-1)
1 file modified
src/wui/game_summary.cc (+1/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug1790456_game_summary
Reviewer Review Type Date Requested Status
Widelands Developers Pending
Review via email: mp+355895@code.launchpad.net

Commit message

fixed the bug 1790456
status and gametime are shown again in game summary window.

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4082. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/435374102.
Appveyor build 3878. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug1790456_game_summary-3878.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Actually, the "time" column is completely superfluous, because it's the same for all players - we're showing the "Elapsed time" on the bottom, that is enough.

I think we should just get rid of it, or will it with the score instead. Then we can fill the "player info" area with more detailed info for Build 21.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

As this bug is targeted for b20, the question is what to do for the moment being?

I would vote for having this in the state as for b19 (that's why I didn't any further changes). And do the changes you proposed for b21.
Otherwise we would have another string to translate and other implications

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

BTW time isn't completly superfluous as it shows the player end time - normally this is the total game time for the winner and last opponent but it is different for a player who lost early (i.e. lost it's last headquarters)
From my imagination this might be interesting in multiplayer games, at least it isn't the same information as in the bottom line.

I tested this with this branch.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Ah, that's a case I didn't think of. Good catch!

Let's have it then :)

@bunnybot merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/wui/game_summary.cc'
2--- src/wui/game_summary.cc 2018-05-31 18:01:27 +0000
3+++ src/wui/game_summary.cc 2018-09-30 21:05:46 +0000
4@@ -102,7 +102,7 @@
5 players_table_->add_column(150, _("Player"));
6 players_table_->add_column(80, _("Team"), "", UI::Align::kCenter);
7 players_table_->add_column(100, _("Status"), "", UI::Align::kCenter);
8- players_table_->add_column(0, _("Time"), "", UI::Align::kRight, UI::TableColumnType::kFlexible);
9+ players_table_->add_column(100, _("Time"), "", UI::Align::kCenter);
10
11 // Prepare Elements
12 title_area_->set_fontsize(UI_FONT_SIZE_BIG);

Subscribers

People subscribed via source and target branches

to status/vote changes: