Merge lp:~widelands-dev/widelands/bug1206563 into lp:widelands

Proposed by cghislai
Status: Merged
Merged at revision: 6683
Proposed branch: lp:~widelands-dev/widelands/bug1206563
Merge into: lp:widelands
Diff against target: 12 lines (+2/-0)
1 file modified
src/logic/queue_cmd_factory.cc (+2/-0)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug1206563
Reviewer Review Type Date Requested Status
Widelands Developers Pending
Review via email: mp+177721@code.launchpad.net

Description of the change

Quick fix for the linked bug

To post a comment you must log in.
Revision history for this message
SirVer (sirver) wrote :

very wonderful.

I think this would not have needed a review :). Feel free to commit things like this directly into trunk - but always make sure that you are merging into trunk and push this (never merge trunk into your working branch and push this, as this changes history and ends in a huge mail bomb).

I think code reviews are very useful for all involved - they should not be a burden though, but always help. So do not think of them as a necessary, but use them to your advantage. I personally send everything that is > 10 lines (roughly) for review.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/logic/queue_cmd_factory.cc'
2--- src/logic/queue_cmd_factory.cc 2013-07-26 20:19:36 +0000
3+++ src/logic/queue_cmd_factory.cc 2013-07-30 23:29:30 +0000
4@@ -99,6 +99,8 @@
5 return *new Cmd_DismantleBuilding ();
6 case QUEUE_CMD_EVICTWORKER:
7 return *new Cmd_EvictWorker();
8+ case QUEUE_CMD_MILITARYSITESETSOLDIERPREFERENCE:
9+ return *new Cmd_MilitarySiteSetSoldierPreference();
10 default:
11 throw wexception("Unknown Queue_Cmd_Id in file: %u", id);
12 }

Subscribers

People subscribed via source and target branches

to status/vote changes: