Merge lp:~widelands-dev/widelands/bug-1842396-no-tribe into lp:widelands
Proposed by
Notabilis
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 9197 | ||||
Proposed branch: | lp:~widelands-dev/widelands/bug-1842396-no-tribe | ||||
Merge into: | lp:widelands | ||||
Diff against target: |
69 lines (+13/-9) 4 files modified
src/logic/game_settings.h (+4/-1) src/network/gameclient.cc (+7/-4) src/network/gamehost.cc (+1/-2) src/wlapplication.cc (+1/-2) |
||||
To merge this branch: | bzr merge lp:~widelands-dev/widelands/bug-1842396-no-tribe | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
GunChleoc | Approve | ||
Review via email: mp+372281@code.launchpad.net |
Commit message
Fixing crash when no tribe is selected for a multiplayer client.
Description of the change
Fixing a crash with showing loading screen tips when no tribe is selected for a multiplayer client.
Seems to be a copy&paste or refactoring bug: When creating the tips as a single player or multiplayer host, the check for the thrown exception is done.
To post a comment you must log in.
Continuous integration builds have changed state:
Travis build 5387. State: failed. Details: https:/ /travis- ci.org/ widelands/ widelands/ builds/ 580833741. /ci.appveyor. com/project/ widelands- dev/widelands/ build/_ widelands_ dev_widelands_ bug_1842396_ no_tribe- 5157.
Appveyor build 5157. State: success. Details: https:/