Merge lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 9022
Proposed branch: lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt
Merge into: lp:widelands
Diff against target: 10 lines (+1/-0)
1 file modified
src/editor/ui_menus/main_menu_save_map.cc (+1/-0)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt
Reviewer Review Type Date Requested Status
hessenfarmer Approve
Review via email: mp+364705@code.launchpad.net

Commit message

After successfully saving a map, mark it as not needing saving.

Description of the change

The marker got lost when we added some safeguards for file system access while saving.

To post a comment you must log in.
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Looks good for me

@bunnybot merge

review: Approve
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4612. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/508113297.
Appveyor build 4399. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1820036_map_saving_prompt-4399.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/editor/ui_menus/main_menu_save_map.cc'
2--- src/editor/ui_menus/main_menu_save_map.cc 2019-02-23 11:00:49 +0000
3+++ src/editor/ui_menus/main_menu_save_map.cc 2019-03-18 21:12:55 +0000
4@@ -333,6 +333,7 @@
5 if (error == GenericSaveHandler::Error::kSuccess ||
6 error == GenericSaveHandler::Error::kDeletingBackupFailed) {
7 egbase.get_ibase()->log_message(_("Map saved"));
8+ eia().set_need_save(false);
9 return true;
10 }
11

Subscribers

People subscribed via source and target branches

to status/vote changes: