Merge lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt into lp:widelands

[GunChleoc]

After successfully saving a map, mark it as not needing saving.

The marker got lost when we added some safeguards for file system access while saving.

[hessenfarmer (stephan-lutz)]

Looks good for me

@bunnybot merge

review: Approve

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 4612. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/508113297.
Appveyor build 4399. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1820036_map_saving_prompt-4399.

=== modified file 'src/editor/ui_menus/main_menu_save_map.cc'
--- src/editor/ui_menus/main_menu_save_map.cc	2019-02-23 11:00:49 +0000
+++ src/editor/ui_menus/main_menu_save_map.cc	2019-03-18 21:12:55 +0000
@@ -333,6 +333,7 @@
 	if (error == GenericSaveHandler::Error::kSuccess ||
 	    error == GenericSaveHandler::Error::kDeletingBackupFailed) {
 		egbase.get_ibase()->log_message(_("Map saved"));
+		eia().set_need_save(false);
 		return true;
 	}