Code review comment for lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial

Revision history for this message
kaputtnik (franku) wrote :

Looks like bunnybot is in winter sleep ...

The travis error is about curl, and i would wonder if the changes would affect building widelands at all, since only some lua code is changed.

> But if notabilis implements the single- multiplayer?-method we wouldn't need this branch here...

I think we need this change in this branch to get closer to the next official release. And i think the changes are straightforward and do not change anything for the players.

Implementing a single/multiplayer switch does not affect this branch, except the documentation. It would 'only' harden the codebase against possible mistakes when using the wrong functions, imho.

I will create a new bug report to make the single/multiplayer mode accessible in lua, and merge this branch by hand.

« Back to merge proposal