Merge lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands

Proposed by Notabilis
Status: Merged
Merged at revision: 9074
Proposed branch: lp:~widelands-dev/widelands/bug-1809838-document-mill
Merge into: lp:widelands
Diff against target: 12 lines (+1/-1)
1 file modified
data/tribes/buildings/productionsites/atlanteans/mill/helptexts.lua (+1/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug-1809838-document-mill
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+364704@code.launchpad.net

Commit message

Documenting "strange" behavior of atlanteans mill for players.

Description of the change

The mill is always grinding blackroot, even when the economy target is met. This branch documents this behavior for players so it isn't considered/reported as bug.

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) wrote :

Text looks good, Can you make it translatable, please?

pgettext("atlanteans_building", text)

Let's have it for Build 21 so we won't break string freeze again.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4613. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/508113746.
Appveyor build 4400. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1809838_document_mill-4400.

9023. By Notabilis

Making helptext of mill translatable.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4631. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/510422490.
Appveyor build 4418. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1809838_document_mill-4418.

Revision history for this message
GunChleoc (gunchleoc) :
review: Approve
Revision history for this message
GunChleoc (gunchleoc) wrote :

@bunnybot merge force

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/tribes/buildings/productionsites/atlanteans/mill/helptexts.lua'
2--- data/tribes/buildings/productionsites/atlanteans/mill/helptexts.lua 2018-05-04 20:38:53 +0000
3+++ data/tribes/buildings/productionsites/atlanteans/mill/helptexts.lua 2019-03-23 21:03:46 +0000
4@@ -18,7 +18,7 @@
5
6 function building_helptext_note()
7 -- TRANSLATORS#: Note helptext for a building
8- return ""
9+ return pgettext("atlanteans_building", "When no cornmeal is required, the mill will try to produce blackroot flour even when there is no demand for it.")
10 end
11
12 function building_helptext_performance()

Subscribers

People subscribed via source and target branches

to status/vote changes: