Merge lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands

[GunChleoc]

Fix initialization of last player dropdown in editor player menu

Player number start with 1, not with 0...

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 4137. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/441494752.
Appveyor build 3934. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1797531_playermenu_tribe-3934.

[Notabilis (notabilis27)]

Code is looking good and last player has no longer the "random" tribe.

review: Approve

[GunChleoc (gunchleoc)]

Thanks!

@bunnybot merge

=== modified file 'src/editor/ui_menus/player_menu.cc'
--- src/editor/ui_menus/player_menu.cc	2018-08-28 18:27:59 +0000
+++ src/editor/ui_menus/player_menu.cc	2018-10-15 05:06:59 +0000
@@ -184,7 +184,7 @@
 		}
 
 		plr_tribe->select(
-		   (p < map.get_nrplayers() && Widelands::tribe_exists(map.get_scenario_player_tribe(p))) ?
+		   (p <= map.get_nrplayers() && Widelands::tribe_exists(map.get_scenario_player_tribe(p))) ?
 		      map.get_scenario_player_tribe(p) :
 		      "");
 		plr_tribe->selected.connect(