Merge lp:~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 8797
Proposed branch: lp:~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center
Merge into: lp:widelands
Diff against target: 98 lines (+10/-8)
4 files modified
debian/org.widelands.widelands.desktop (+3/-3)
debian/org.widelands.widelands.desktop.stub (+1/-1)
debian/widelands.appdata.xml (+3/-2)
debian/widelands.appdata.xml.stub (+3/-2)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center
Reviewer Review Type Date Requested Status
Widelands Developers Pending
Review via email: mp+353752@code.launchpad.net

Commit message

Fixes for Debian-based software centers

- Add stock icon to appdata.xml (c.f. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857644)
- Change icon definition in .desktop to be a generic one
- Content ratings are now accepted by the validator, so we've activated them

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) wrote :

@bunnybot merge

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 3837. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/420887783.
Appveyor build 3635. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1789023_fix_icon_for_software_center-3635.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/org.widelands.widelands.desktop'
2--- debian/org.widelands.widelands.desktop 2018-07-28 11:03:59 +0000
3+++ debian/org.widelands.widelands.desktop 2018-08-26 10:54:52 +0000
4@@ -43,14 +43,14 @@
5 Comment=A real-time build-up strategy game
6 Comment[ar]=لعبة بناء إستراتيجية في الوقت الحقيقي
7 Comment[bg]=Стратегическа игра за изграждане на цивилизация в реално време
8-Comment[ca]=Un joc d'estratègia i construcció a temps real
9+Comment[ca]=Un joc d'estratègia i construcció a temps real
10 Comment[cs]=Real-time budovatelská strategická hra
11 Comment[da]=Et realtids opbygningsstrategispil
12 Comment[de]=Echtzeitbasiertes Aufbau-Strategiespiel
13 Comment[es]=Un juego de estrategia y construcción en tiempo real
14 Comment[eu]=Denbora errealeko eraikuntza eta estrategia jokoa
15 Comment[fi]=Reaaliaikainen strategiapeli
16-Comment[fr]=Un jeu de stratégie et de construction en temps réel
17+Comment[fr]=Un jeu de stratégie et de construction en temps réel
18 Comment[fy]=In strategysk bouwspultsje mei rinnende tiid
19 Comment[gd]=Geama ro-innleachd togail fìor-ama
20 Comment[hu]=Egy valós idejű, építkezős stratégiai játék
21@@ -71,7 +71,7 @@
22 Comment[sv]=Ett uppbyggnadsstrategispel i realtid
23 Comment[uk]=Стратегічна гра у режимі реального часу
24 Comment[zh_TW]=一款即時演變的策略遊戲
25-Icon=/usr/share/games/widelands/data/images/logos/wl-ico-64.png
26+Icon=widelands
27 TryExec=widelands
28 Exec=widelands
29 Categories=Game;StrategyGame;
30
31=== modified file 'debian/org.widelands.widelands.desktop.stub'
32--- debian/org.widelands.widelands.desktop.stub 2018-07-28 11:03:59 +0000
33+++ debian/org.widelands.widelands.desktop.stub 2018-08-26 10:54:52 +0000
34@@ -3,7 +3,7 @@
35 Type=Application
36 Name=Widelands
37 GENERIC_NAME_COMMENT_HOOK
38-Icon=/usr/share/games/widelands/data/images/logos/wl-ico-64.png
39+Icon=widelands
40 TryExec=widelands
41 Exec=widelands
42 Categories=Game;StrategyGame;
43
44=== modified file 'debian/widelands.appdata.xml'
45--- debian/widelands.appdata.xml 2018-07-06 14:23:53 +0000
46+++ debian/widelands.appdata.xml 2018-08-26 10:54:52 +0000
47@@ -5,6 +5,7 @@
48 <metadata_license>CC0-1.0</metadata_license>
49 <project_license>GPL-2.0</project_license>
50 <name>Widelands</name>
51+ <icon type="stock">widelands</icon>
52 <summary>A real-time build-up strategy game</summary>
53 <summary xml:lang="ar">لعبة بناء إستراتيجية في الوقت الحقيقي</summary>
54 <summary xml:lang="bg">Стратегическа игра за изграждане на цивилизация в реално време</summary>
55@@ -286,7 +287,7 @@
56 <url type="donation">https://wl.widelands.org/wiki/The%20Widelands%20Project/</url>
57 <url type="help">https://wl.widelands.org/wiki/Game%20Manual/</url>
58 <developer_name>The Widelands Development Team</developer_name>
59- <x-content_rating type="oars-1.0">
60+ <content_rating type="oars-1.0">
61 <content_attribute id="violence-cartoon">moderate</content_attribute>
62 <content_attribute id="violence-fantasy">none</content_attribute>
63 <content_attribute id="violence-realistic">none</content_attribute>
64@@ -307,5 +308,5 @@
65 <content_attribute id="social-contacts">none</content_attribute>
66 <content_attribute id="money-purchasing">none</content_attribute>
67 <content_attribute id="money-gambling">none</content_attribute>
68- </x-content_rating>
69+ </content_rating>
70 </component>
71
72=== modified file 'debian/widelands.appdata.xml.stub'
73--- debian/widelands.appdata.xml.stub 2017-08-26 09:24:28 +0000
74+++ debian/widelands.appdata.xml.stub 2018-08-26 10:54:52 +0000
75@@ -5,6 +5,7 @@
76 <metadata_license>CC0-1.0</metadata_license>
77 <project_license>GPL-2.0</project_license>
78 <name>Widelands</name>
79+ <icon type="stock">widelands</icon>
80 SUMMARY_DESCRIPTION_HOOK
81 <screenshots>
82 <screenshot type="default">
83@@ -56,7 +57,7 @@
84 <url type="donation">https://wl.widelands.org/wiki/The%20Widelands%20Project/</url>
85 <url type="help">https://wl.widelands.org/wiki/Game%20Manual/</url>
86 <developer_name>The Widelands Development Team</developer_name>
87- <x-content_rating type="oars-1.0">
88+ <content_rating type="oars-1.0">
89 <content_attribute id="violence-cartoon">moderate</content_attribute>
90 <content_attribute id="violence-fantasy">none</content_attribute>
91 <content_attribute id="violence-realistic">none</content_attribute>
92@@ -77,5 +78,5 @@
93 <content_attribute id="social-contacts">none</content_attribute>
94 <content_attribute id="money-purchasing">none</content_attribute>
95 <content_attribute id="money-gambling">none</content_attribute>
96- </x-content_rating>
97+ </content_rating>
98 </component>

Subscribers

People subscribed via source and target branches

to status/vote changes: