Code review comment for lp:~widelands-dev/widelands/bug-1489295-mine-is-exhausted

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I don't get this.

According to your log the Production result was set properly so why do we need the empty string check?

and why doing it that complicated

why not

if ( ps.production_result() != ps.descr().out_of_resource_heading() || ps.descr().out_of_resource_heading().empty()) {
   ps.set_production_result(result_string);
  }

« Back to merge proposal