lp:~widelands-dev/widelands/bug-1377642-iterator-loops

Created by GunChleoc on 2017-08-21 and last modified on 2019-09-14
Get this branch:
bzr branch lp:~widelands-dev/widelands/bug-1377642-iterator-loops
Members of Widelands Developers can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Widelands Developers
Project:
widelands
Status:
Abandoned

Recent revisions

8432. By GunChleoc on 2019-09-08

Merged trunk.

8431. By GunChleoc on 2017-08-21

Replaced iterator loops with range-based for loops.

8430. By Wideland's Bunnybot <email address hidden> on 2017-08-19

Merged lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized_variables2:
Fixed a bunch of "Member variable is not initialized in the constructor" warnings from cppcheck. Some code style tweaks to ManagementData.

8429. By Wideland's Bunnybot <email address hidden> on 2017-08-19

Merged lp:~widelands-dev/widelands/ai_trainingsites:
Second and further traininsites of the type is built only if current one are busy enough...

8428. By Wideland's Bunnybot <email address hidden> on 2017-08-18

Merged lp:~widelands-dev/widelands/cleanup_mapview:
Start to detangle MapView and InteractiveBase.

MapView was a base class of InteractiveBase, but still requires InteractiveBase to be passed. My plan is to change MapView to probably not even be a UI::Panel anymore (unclear yet), but for sure change inheritance to composition and remove more logic knowledge from MapView.

I also did a few cleanups in InteractiveBase.

Full changes:
- Inheritance to composition for MapView.
- removed some public member variables
- reduced visibility of some 'protected' variables.
- removed PIMPL idiom from InteractiveBase.

8427. By Wideland's Bunnybot <email address hidden> on 2017-08-18

Merged lp:~widelands-dev/widelands/ai_training_switch:
The ai training mode is triggered now from the command line. There are 2 switches:

  --ai_training: Dumps new AI files in home folder and uses higher mutation ratios

  --auto_speed: Activates auto-speed in multiplayer games

8426. By Wideland's Bunnybot <email address hidden> on 2017-08-17

Merged lp:~widelands-dev/widelands/remove_make_infrastructure_tool:
Remove make infrastructure tool.

This tool was supposed to make it possible to create an economy in the editor. This would be great for scenarios, but did not work properly (that is why the UI was not wired up). It is also unclear how this would interact with Lua scripting (which came after this prototype was implemented). Time to kill this dead code.

8425. By GunChleoc on 2017-08-17

Fetched translations and updated catalogues.

8424. By Wideland's Bunnybot <email address hidden> on 2017-08-16

Merged lp:~widelands-dev/widelands/bug-1664052-expedition-shipwindow-crash:
Do not delete/recreate buttons in the ship window. This fixes a segfault with the button signals. This also makes NoteShipWindow::Action::kRefresh obsolete. Also, some layout tweaks to the shipwindow.

8423. By Wideland's Bunnybot <email address hidden> on 2017-08-16

Merged lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables:
Initialize a bunch of uninitialized member variables, adding constructors where necessary. Turned some enums into enum classes. Removed empty string initializations.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:widelands
This branch contains Public information 
Everyone can see this information.