Code review comment for lp:~widelands-dev/widelands/amazons-coding-changes

Benedikt Straub (nordfriese) wrote :

Fixed the fieldaction bug and split off FindNodeTerraform.
New terraform syntax:
 "findspace=size:any radius:6 terraform",

There´s no real reason why we need a World or EGBase in Tool parameters, is there? I removed it, as it can be fetched directly from the provided EIA.

I would prefer to keep the EGBase parameter in FindNode::accept. For now World and Map would suffice, but if we want to write some other new worker program for a new tribe someday (e.g. a forester that plants trees only in the territory of enemy players?) there´s no way around an EGBase param, no need to do the whole rework again then IMHO.

« Back to merge proposal