Merge lp:~widelands-dev/widelands-website/screshot_ordering into lp:widelands-website
Status: | Merged |
---|---|
Merged at revision: | 532 |
Proposed branch: | lp:~widelands-dev/widelands-website/screshot_ordering |
Merge into: | lp:widelands-website |
Diff against target: |
281 lines (+144/-44) 8 files modified
notification/migrations/0003_auto_20190409_0924.py (+20/-0) wlhelp/migrations/0002_auto_20190410_1734.py (+36/-0) wlscreens/admin.py (+7/-0) wlscreens/migrations/0002_auto_20190410_1737.py (+28/-0) wlscreens/models.py (+44/-25) wlscreens/templates/wlscreens/index.html (+1/-0) wlscreens/urls.py (+1/-2) wlscreens/views.py (+7/-17) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands-website/screshot_ordering |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
GunChleoc | Approve | ||
Review via email: mp+365763@code.launchpad.net |
Commit message
Allow ordering of screenshots by applying a new database column.
Description of the change
Add a new database column 'position' to the model of wlscreens_
In the admin page a list of screenshots is added to a category. E.g. clicking on Category 'Build 20' all screenshots for 'Build 20' will be listet. One can edit (upload, change) the screenshots in this list. So one don't have to edit each screenshot by its own.
Removed: url for displaying screenshots by one category, which leads only into a 404.
Changed: Replaced the view function with a django class based view.
I thought also to have the screenshot list paginated, to speed up loading time, but i didn't found a good solution to display the pagination bar. This can be done later on.
To get this in:
merge the branch
run: ./manage.py migrate
restart the website
LGTM. Thanks for implementing this :)