Merge lp:~widelands-dev/widelands-website/official_posts into lp:widelands-website
Proposed by
kaputtnik
Status: | Merged |
---|---|
Merged at revision: | 529 |
Proposed branch: | lp:~widelands-dev/widelands-website/official_posts |
Merge into: | lp:widelands-website |
Diff against target: |
129 lines (+40/-31) 4 files modified
pybb/feeds.py (+3/-7) pybb/models.py (+27/-2) pybb/templatetags/pybb_extras.py (+8/-12) pybb/views.py (+2/-10) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands-website/official_posts |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
GunChleoc | Approve | ||
kaputtnik (community) | Needs Resubmitting | ||
Review via email: mp+364989@code.launchpad.net |
Commit message
Unify getting of official posts; performance tweaks
Description of the change
This branch makes gathering of official posts (= posts for normal users) easier, because it is defined in one place. This applies for the places were ALL posts needed filtering: feeds, the new latest posts page and the Last Posts box.
This branch boosts also performance: E.g. in my test environment gathering the last 1000 posts in the new latest posts view lasts:
- with trunk: ~0.4 sec
- with this branch: ~0.04 sec
This scales good also for all posts (9107 on my testsystem):
- trunk: 18 sec.
- this branch: 0.09 sec.
To post a comment you must log in.
I think the word "official" is confusing here - I associate public announcements and sticky topics with that. I think we should call them "public".
Code LGTM otherwise :)