Code review comment for lp:~widelands-dev/widelands-website/notifications_cleanup

kaputtnik (franku) wrote :

Merged and deployed. I have created a cron job /etc/cron.20minutesly/django_commands.

First i forgot to make the script executable, so the first emailing didn't work. Lets see if it works after making the script executable.

The command used in /etc/cron.daily/django_regular_commands had a comment:

# Was unable to quiet the next command - we will likely never seen when it fails
/var/www/django_projects/wlwebsite/bin/python emit_notices 2> /dev/null

I removed the complete part from there and put in /etc/cron.20minutesly/django_commands, and use it in there without the redirect (>2 /dev/null). I am not sure where the output of this command will be written. I checked /var/log/upstart/wl.log and /var/log/nginx/wlwebsite.log but cant see anything in there.
Since i have adjusted the code to make this command not so chattering, it may be ok as it is?

« Back to merge proposal