Merge lp:~widelands-dev/widelands-website/inbox_link into lp:widelands-website

Proposed by kaputtnik
Status: Merged
Merged at revision: 510
Proposed branch: lp:~widelands-dev/widelands-website/inbox_link
Merge into: lp:widelands-website
Diff against target: 17 lines (+4/-3)
1 file modified
templates/header.html (+4/-3)
To merge this branch: bzr merge lp:~widelands-dev/widelands-website/inbox_link
Reviewer Review Type Date Requested Status
Widelands Developers Pending
Review via email: mp+359673@code.launchpad.net

Commit message

Link directly to PMs inbox if new message(s) are avialable.

Description of the change

I new PMs are available the link 'Your Profile (#)' links directly to the inbox, otherwise the link 'Your Profile' links to the profile page.

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) wrote :

I'm not sue if the distinction makes for good usability. Let's deploy this though to see how it handles in production and whether it's confusing or not.

Revision history for this message
kaputtnik (franku) wrote :

Merged and deployed. I have send you a PM so you can test.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/header.html'
2--- templates/header.html 2018-10-30 14:46:45 +0000
3+++ templates/header.html 2018-11-28 08:13:37 +0000
4@@ -31,9 +31,10 @@
5 <li class="loginBox small">
6 <!-- Login form / User information -->
7 {% if user.is_authenticated %}
8- <a href="{% url 'profile_view' %}" title="You are logged in as {{ user }}">Your Profile</a>
9- {% if messages_inbox_count > 0 %}
10- <a href="{% url 'messages_inbox' %}" title="Number of Private Messages">({{ messages_inbox_count }})</a>
11+ {% if messages_inbox_count %}
12+ <a href="{% url 'messages_inbox' %}" title="Show Inbox">Your Profile ({{ messages_inbox_count }})</a>
13+ {% else %}
14+ <a href="{% url 'profile_view' %}" title="Show Profile">Your Profile</a>
15 {% endif %}
16 <br />
17 <a href="{% url 'scheduling_find' %}?next={{ request.path|iriencode }}" title="Show other users playtimes">Playtimes</a>

Subscribers

People subscribed via source and target branches