Merge lp:~widelands-dev/widelands-website/custom_user_admin_page into lp:widelands-website

[kaputtnik]

Since i deleted two users today i got bored with the admin page showing all users in a list, sorted by username. Everytime one has to search for the user he wants to delete, while the most time a spammer has registered within the last few days. So i thought to order the list by 'date_joined' and made some other changes to make the work a bit easier:

Removed columns: 'last_name' and 'first_name'
Added columns: 'date_joined', 'last_login' and 'is_active'
Ordering is changed from 'username' to 'date_joined' showing the recent joined users first

All columns are sortable.

[lp:~widelands-dev/widelands-website/custom_user_admin_page]

474. By kaputtnik on 2017-10-01

merged with trunk

[GunChleoc (gunchleoc)]

I think this is a great idea :D

LGTM, not tested.

review: Approve

[kaputtnik (franku)]

Thanks, merged and deployed :-)

[kaputtnik (franku)]

Quite interesting how many users had registered but never activated the account ;)

https://wl.widelands.org/admin/auth/user/?o=5

[GunChleoc (gunchleoc)]

I'm in favour of deleting those accounts. It will make the list of usernames to trawl through shorter when posting news etc.

[kaputtnik (franku)]

I have deleted the non active accounts where the activation date expired. In total ~140 users.

> It will make the list of usernames to trawl through shorter when posting news etc.

Normally the one who will write a news post is the one who opens the appropriate admin page. So i think in the list of usernames the current user should be marked/chosen automatically.

[GunChleoc (gunchleoc)]

Should, but isn't, at least not the last time I posted to the news page. Maybe I'm overlooking something?

[kaputtnik (franku)]

Sorry this was meant to be a 'will have': bug 1723640

[GunChleoc (gunchleoc)]

So I wasn't being blind then :)

[GunChleoc (gunchleoc)]

I waned to give this a quick spin while the Alpha site is up, but I don't have admin privileges.

[kaputtnik (franku)]

Sorry i don't understand what you mean. This branch is already merged so you could watch it on wl.widelands.org?

[GunChleoc (gunchleoc)]

Sorry, I didn't see that it was already merged.

=== modified file 'wlprofile/admin.py'
--- wlprofile/admin.py	2016-12-13 18:28:51 +0000
+++ wlprofile/admin.py	2017-10-01 08:12:20 +0000
@@ -12,6 +12,8 @@
 from django.utils.translation import ugettext_lazy as _
 from django.contrib import admin
 from models import Profile
+from django.contrib.auth.models import User
+from django.contrib.auth.admin import UserAdmin
 
 
 class ProfileAdmin(admin.ModelAdmin):
@@ -37,3 +39,18 @@
     )
 
 admin.site.register(Profile, ProfileAdmin)
+
+
+class CustomUserAdmin(UserAdmin):
+    """Partly overwritten admin page for django auth.user.
+
+    Replaces in users list: 'first_name' with 'date_joined' and
+    'last_name' with 'is_active'. Added column: 'last_login'.
+
+    """
+    list_display = ('username', 'email', 'date_joined', 'last_login',
+                    'is_active', 'is_staff')
+    ordering = ('-date_joined',)
+
+admin.site.unregister(User)
+admin.site.register(User, CustomUserAdmin)