Merge lp:~widelands-dev/widelands-website/css_border into lp:widelands-website

Proposed by kaputtnik
Status: Merged
Merged at revision: 534
Proposed branch: lp:~widelands-dev/widelands-website/css_border
Merge into: lp:widelands-website
Diff against target: 24 lines (+5/-1)
1 file modified
mainpage/static/css/base.css (+5/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands-website/css_border
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+366075@code.launchpad.net

Commit message

Use a css-border for the landing image

Description of the change

Not sure if we should use the 'round' property instead of 'repeat'. -> https://caniuse.com/#search=border-image

Some browsers don't support this feature.

Example image: https://i.ibb.co/S3k6WCc/landing-image-border.jpg

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) wrote :

According to that list, only Opera Mini and Blackberry don't support the "round" parameter, so I'd say the coverage is pretty good.

Screenshot looks good :)

review: Approve
Revision history for this message
kaputtnik (franku) wrote :

Thanks.

Merged and deployed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mainpage/static/css/base.css'
2--- mainpage/static/css/base.css 2018-11-21 06:21:45 +0000
3+++ mainpage/static/css/base.css 2019-04-15 21:29:55 +0000
4@@ -409,6 +409,10 @@
5 img.landing {
6 margin-left: 20px;
7 margin-bottom: 15px;
8+ border: 10px solid transparent;
9+ border-image: url(../img/image_border.png) 20 round;
10+ -webkit-border-image: url(../img/image_border.png) 20 round; /* Safari 3.1-5 */
11+ -o-border-image: url(../img/image_border.png) 20 round; /* Opera 11-12.1 */
12 }
13
14 div.blogEntry {
15@@ -544,4 +548,4 @@
16 justify-content: center;
17 margin-bottom: 10px !important;
18 }
19-}
20\ No newline at end of file
21+}
22
23=== added file 'mainpage/static/img/image_border.png'
24Binary files mainpage/static/img/image_border.png 1970-01-01 00:00:00 +0000 and mainpage/static/img/image_border.png 2019-04-15 21:29:55 +0000 differ

Subscribers

People subscribed via source and target branches