Merge lp:~widelands-dev/widelands-website/bug-1750102_map_admin_page into lp:widelands-website

Proposed by kaputtnik
Status: Merged
Merged at revision: 484
Proposed branch: lp:~widelands-dev/widelands-website/bug-1750102_map_admin_page
Merge into: lp:widelands-website
Diff against target: 50 lines (+19/-4)
2 files modified
wlmaps/admin.py (+17/-2)
wlmaps/models.py (+2/-2)
To merge this branch: bzr merge lp:~widelands-dev/widelands-website/bug-1750102_map_admin_page
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+338767@code.launchpad.net

Description of the change

Allow some columns of table wlmaps_map to be empty. This makes renaming a map possible.

Also reworked the admin page of wlmaps and split into some sections.

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) wrote :

LGTM :)

review: Approve
485. By kaputtnik

merged trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'wlmaps/admin.py'
2--- wlmaps/admin.py 2016-02-09 18:05:18 +0000
3+++ wlmaps/admin.py 2018-02-24 15:35:57 +0000
4@@ -7,9 +7,24 @@
5
6
7 class MapAdmin(admin.ModelAdmin):
8+ list_display = ['name', 'author', 'pub_date']
9 prepopulated_fields = {'slug': ('name',)}
10 search_fields = ['name', 'author']
11- list_display = ['name', 'author', 'pub_date']
12 list_filter = ['pub_date']
13-
14+ readonly_fields = ('uploader', 'nr_players', 'w', 'h', 'minimap', 'file', 'world_name')
15+ fieldsets = (
16+ (None, {
17+ 'fields': (('name', 'author'), 'uploader', 'uploader_comment')
18+ }),
19+ ('Map properties', {
20+ 'classes': ('collapse',),
21+ 'fields': ('descr', 'hint', 'world_name',
22+ ('nr_players', 'w', 'h')
23+ )
24+ }),
25+ ('Upload information', {
26+ 'classes': ('collapse',),
27+ 'fields': ('minimap', 'file', 'pub_date', 'nr_downloads', 'slug')
28+ }),
29+ )
30 admin.site.register(Map, MapAdmin)
31
32=== modified file 'wlmaps/models.py'
33--- wlmaps/models.py 2018-01-14 10:37:20 +0000
34+++ wlmaps/models.py 2018-02-24 15:35:57 +0000
35@@ -22,13 +22,13 @@
36 nr_players = models.PositiveIntegerField(verbose_name='Max Players')
37
38 descr = models.TextField(verbose_name='Description')
39- hint = models.TextField(verbose_name='Hint')
40+ hint = models.TextField(verbose_name='Hint', blank=True)
41 minimap = models.ImageField(
42 verbose_name='Minimap', upload_to='wlmaps/minimaps')
43 file = models.FileField(verbose_name='Mapfile',
44 upload_to='wlmaps/maps')
45
46- world_name = models.CharField(max_length=50)
47+ world_name = models.CharField(max_length=50, blank=True)
48
49 pub_date = models.DateTimeField(default=datetime.datetime.now)
50 uploader_comment = models.TextField(

Subscribers

People subscribed via source and target branches